O(1) SkPictureUtils::ApproxBytesUsed()

O(1) SkPictureUtils::ApproxBytesUsed()

Chrome wants to call this more often, and it's quite slow today.

Seems like this could be clearer if SkPictureUtils::ApproxBytesUsed() were SkPicture::approxBytesUsed().

BUG=chromium:471873
Committed: https://skia.googlesource.com/skia/+/98b8485a4cc911420e20af2670d21a5478a06264

[mtklein_C, 2015-04-21 17:59:42]

mtklein@chromium.org changed reviewers:
+ reed@google.com, robertphillips@google.com

[mtklein_C, 2015-04-21 17:59:51]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 18:00:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090943004/20001

[commit-bot: I haz the power, 2015-04-21 18:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 18:05:30]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-04-21 22:13:04]

https://codereview.chromium.org/1090943004/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1090943004/diff/20001/include/core/SkPicture....
include/core/SkPicture.h:277: size_t                               
fApproxBytesUsedBySubPictures;
can this field be const?

https://codereview.chromium.org/1090943004/diff/20001/src/core/SkPictureRecor...
File src/core/SkPictureRecorder.cpp (right):

https://codereview.chromium.org/1090943004/diff/20001/src/core/SkPictureRecor...
src/core/SkPictureRecorder.cpp:78: subPictureBytes +=
SkPictureUtils::ApproximateBytesUsed(pictList->begin()[i]);
why call the utils version here?

https://codereview.chromium.org/1090943004/diff/20001/src/core/SkPictureRecor...
src/core/SkPictureRecorder.cpp:164: subPictureBytes +=
SkPictureUtils::ApproximateBytesUsed(pictList->begin()[i]);
... and here?

[mtklein, 2015-04-21 22:18:22]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[mtklein, 2015-04-21 22:18:31]

https://codereview.chromium.org/1090943004/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1090943004/diff/20001/include/core/SkPicture....
include/core/SkPicture.h:277: size_t                               
fApproxBytesUsedBySubPictures;
On 2015/04/21 22:13:04, reed1 wrote:
> can this field be const?

Yes, done.

https://codereview.chromium.org/1090943004/diff/20001/src/core/SkPictureRecor...
File src/core/SkPictureRecorder.cpp (right):

https://codereview.chromium.org/1090943004/diff/20001/src/core/SkPictureRecor...
src/core/SkPictureRecorder.cpp:78: subPictureBytes +=
SkPictureUtils::ApproximateBytesUsed(pictList->begin()[i]);
On 2015/04/21 22:13:04, reed1 wrote:
> why call the utils version here?

There is no other version?

Were you expecting a call to a method on SkPicture?  I was too.  For reasons I'm
not too clear on, this method is not a method on SkPicture, but rather siloed
over into another SkPictureUtils class.

[commit-bot: I haz the power, 2015-04-21 22:18:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090943004/40001

[reed1, 2015-04-21 22:20:19]

Ah, I see that all this CL does is to cache the hierarchical answer. Got it.
lgtm

[mtklein, 2015-04-21 22:20:58]

On 2015/04/21 22:20:19, reed1 wrote:
> Ah, I see that all this CL does is to cache the hierarchical answer. Got it.
> lgtm

Right.

[mtklein, 2015-04-21 22:21:03]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-04-21 22:21:10]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-21 22:21:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090943004/40001

[commit-bot: I haz the power, 2015-04-21 22:24:05]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/98b8485a4cc911420e20af2670d21a5478a06264