Issue 10909273: Disable crashing code in the pepper plugin code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909273: Disable crashing code in the pepper plugin code. (Closed)

Created:
8 years, 3 months ago by brettw

Modified:
8 years, 3 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable crashing code in the pepper plugin code. The dispatcher wrapper outlives the render view, so it was an error to save the RenderView pointer and use it later. This patch will break out-of-process gamepad which is currently unused, as well as the async flash device ID which is also currently unused. BUG=149850 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157158

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git try #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
	M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	1 2	4 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages