Avoid using a temp register when unboxing a known smi.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1866 matching lines @@
                                compiler->double_class(),
                                slow_path->entry_label(),
                                Assembler::kFarJump,
                                out_reg);
   __ Bind(slow_path->exit_label());
   __ movsd(FieldAddress(out_reg, Double::value_offset()), value);
 }
 
 
 LocationSummary* UnboxDoubleInstr::MakeLocationSummary() const {
-  const intptr_t v_cid = value()->ResultCid();
-
   const intptr_t kNumInputs = 1;
-  const intptr_t kNumTemps = (v_cid != kDoubleCid) ? 1 : 0;
+  const intptr_t kNumTemps = CanDeoptimize() ? 1 : 0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresRegister());
-  if (v_cid != kDoubleCid) summary->set_temp(0, Location::RequiresRegister());
+  if (CanDeoptimize()) summary->set_temp(0, Location::RequiresRegister());
   summary->set_out(Location::RequiresXmmRegister());
   return summary;
 }
 
 
 void UnboxDoubleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  const intptr_t v_cid = value()->ResultCid();
-
+  const intptr_t value_cid = value()->ResultCid();
   const Register value = locs()->in(0).reg();
   const XmmRegister result = locs()->out().xmm_reg();
-  if (v_cid != kDoubleCid) {
+
+  if (value_cid == kDoubleCid) {
+    __ movsd(result, FieldAddress(value, Double::value_offset()));
+  } else if (value_cid == kSmiCid) {
+    __ SmiUntag(value);  // Untag input before conversion.
+    __ cvtsi2sd(result, value);
+    __ SmiTag(value);  // Restore input register.
+  } else {
     Label* deopt = compiler->AddDeoptStub(deopt_id_, kDeoptBinaryDoubleOp);
     compiler->LoadDoubleOrSmiToXmm(result,
                                    value,
                                    locs()->temp(0).reg(),
                                    deopt);
-  } else {
-    __ movsd(result, FieldAddress(value, Double::value_offset()));
   }
 }
 
 
 LocationSummary* UnboxedDoubleBinaryOpInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
   const intptr_t kNumTemps = 0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresXmmRegister());
@@ skipping 358 matching lines @@
     __ j(ABOVE_EQUAL, deopt);
   }
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64