Share MediaStorageUtil common code among platforms.

chrome/browser/system_monitor/media_storage_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chrome::MediaStorageUtil implementation.
 
 #include "chrome/browser/system_monitor/media_storage_util.h"
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/system_monitor/system_monitor.h"
 #include "content/public/browser/browser_thread.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.h"
+#include "chrome/browser/system_monitor/removable_device_notifications_chromeos.h"
+#elif defined(OS_LINUX)
+#include "chrome/browser/system_monitor/removable_device_notifications_linux.h"
+#elif defined(OS_MACOSX)
+#include "chrome/browser/system_monitor/removable_device_notifications_mac.h"
+#elif defined(OS_WIN)
+#include "chrome/browser/system_monitor/removable_device_notifications_window_win.h"
+#endif
+
 using base::SystemMonitor;
 using content::BrowserThread;
 
 namespace chrome {
 
 namespace {
 
 typedef std::vector<SystemMonitor::RemovableStorageInfo> RemovableStorageInfo;
 
 // Prefix constants for different device id spaces.
@@ skipping 116 matching lines @@
     // We should be able to find removable storage in SystemMonitor.
     callback.Run(!FindRemovableStorageLocationById(device_id).empty());
   }
 }
 
 // static
 bool MediaStorageUtil::GetDeviceInfoFromPath(const FilePath& path,
                                              std::string* device_id,
                                              string16* device_name,
                                              FilePath* relative_path) {
+  if (!path.IsAbsolute())
+    return false;
+
   if (g_test_get_device_info_from_path_function) {
     return g_test_get_device_info_from_path_function(path, device_id,
                                                      device_name,
                                                      relative_path);
-  } else {
-    return GetDeviceInfoFromPathImpl(path, device_id, device_name,
-                                     relative_path);
   }
+
+  bool found_device = false;
+  base::SystemMonitor::RemovableStorageInfo device_info;
+#if (defined(OS_LINUX) || defined(OS_MACOSX)) && !defined(OS_CHROMEOS)
+  RemovableDeviceNotifications* notifier =
+      RemovableDeviceNotifications::GetInstance();
+  found_device = notifier->GetDeviceInfoForPath(path, &device_info);
+#endif
+
+#if 0 && defined(OS_CHROMEOS)

[Lei Zhang, 2012/09/17 00:25:47]

Whose job is it to remove the #if 0 bit and use mtp manager?

[vandebo (ex-Chrome), 2012/09/17 00:32:58]

http://codereview.chromium.org/10908277/ will take care of it shortly.

+  MediaTransferProtocolDeviceObserver* mtp_manager =
+      MediaTransferProtocolDeviceObserver::GetInstance();
+  found_device = mtp_manager->GetStorageInfoForPath(path, &device_info);
+#endif
+
+  if (found_device && IsRemovableDevice(device_info.device_id)) {
+    if (device_id)
+      *device_id = device_info.device_id;
+    if (device_name)
+      *device_name = device_info.name;
+    if (relative_path) {
+      *relative_path = FilePath();
+      FilePath mount_point(device_info.location);
+      mount_point.AppendRelativePath(path, relative_path);
+    }
+    return true;
+  }
+
+#if !defined(POSIX)

[Lei Zhang, 2012/09/17 00:25:47]

OS_POSIX?

[vandebo (ex-Chrome), 2012/09/17 00:32:58]

Done.

+  if (!found_device)
+    return false;
+#endif
+
+  // On Posix systems, there's one root so any absolute path could be valid.
+  if (device_id)
+    *device_id = MakeDeviceId(FIXED_MASS_STORAGE, path.AsUTF8Unsafe());
+  if (device_name)
+    *device_name = path.BaseName().LossyDisplayName();
+  if (relative_path)
+    *relative_path = FilePath();
+  return true;
 }
 
 // static
 FilePath MediaStorageUtil::FindDevicePathById(const std::string& device_id) {
   Type type;
   std::string unique_id;
   if (!CrackDeviceId(device_id, &type, &unique_id))
     return FilePath();
 
   if (type == FIXED_MASS_STORAGE) {
     // For this type, the unique_id is the path.
     return FilePath::FromUTF8Unsafe(unique_id);
   }
 
   DCHECK(type == MTP_OR_PTP ||
          type == REMOVABLE_MASS_STORAGE_WITH_DCIM ||
          type == REMOVABLE_MASS_STORAGE_NO_DCIM);
   return FilePath(FindRemovableStorageLocationById(device_id));
 }
 
 // static
 void MediaStorageUtil::SetGetDeviceInfoFromPathFunctionForTesting(
     GetDeviceInfoFromPathFunction function) {
   g_test_get_device_info_from_path_function = function;
 }
 
 MediaStorageUtil::MediaStorageUtil() {}
 
-#if !defined(OS_LINUX) || defined(OS_CHROMEOS)
-// static
-bool MediaStorageUtil::GetDeviceInfoFromPathImpl(const FilePath& path,
-                                                 std::string* device_id,
-                                                 string16* device_name,
-                                                 FilePath* relative_path) {
-  // TODO(vandebo) This needs to be implemented per platform.  Below is no
-  // worse than what the code already does.
-  // * Find mount point parent (determines relative file path)
-  // * Search System monitor, just in case.
-  // * If it's a removable device, generate device id, else use device root
-  //   path as id
-  if (device_id)
-    *device_id = MakeDeviceId(FIXED_MASS_STORAGE, path.AsUTF8Unsafe());
-  if (device_name)
-    *device_name = path.BaseName().LossyDisplayName();
-  if (relative_path)
-    *relative_path = FilePath();
-  return true;
-}
-#endif
-
 }  // namespace chrome