Issue 10909251: Remove Python < 2.6 compatibility imports from testserver.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909251: Remove Python < 2.6 compatibility imports from testserver.py. (Closed)

Created:
8 years, 3 months ago by mattm

Modified:
8 years, 2 months ago

Reviewers:
M-A Ruel, Ryan Sleevi

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove Python < 2.6 compatibility imports from testserver.py. Split out of https://chromiumcodereview.appspot.com/10073033. BUG=none TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158196

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -18 lines)			Patch
	M	net/tools/testserver/testserver.py	View		5 chunks	+8 lines, -18 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

Running my change in an XP VM I wasn't able to reproduce the problems seen ...

8 years, 3 months ago (2012-09-14 23:15:02 UTC) #1

M-A Ruel

lgtm http://codereview.chromium.org/10909251/diff/1/net/tools/testserver/testserver.py File net/tools/testserver/testserver.py (right): http://codereview.chromium.org/10909251/diff/1/net/tools/testserver/testserver.py#newcode42 net/tools/testserver/testserver.py:42: warnings.filterwarnings("ignore", category=DeprecationWarning) Maybe it's not necessary anymore ?

8 years, 3 months ago (2012-09-14 23:16:08 UTC) #2

mattm

8 years, 3 months ago (2012-09-14 23:21:48 UTC) #3

http://codereview.chromium.org/10909251/diff/1/net/tools/testserver/testserve...
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/10909251/diff/1/net/tools/testserver/testserve...
net/tools/testserver/testserver.py:42: warnings.filterwarnings("ignore",
category=DeprecationWarning)
On 2012/09/14 23:16:08, Marc-Antoine Ruel wrote:
> Maybe it's not necessary anymore ?

Seems like it.

I don't want to introduce extra variables in the equation though, so I'll remove
that in a separate CL if this sticks.

Expand Messages | Collapse Messages