Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: runtime/vm/compiler.cc

Issue 10909200: Fix issues 5137: instance of test on constant value should return true or false, not the value itse… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 // Inlining (mutates the flow graph) 191 // Inlining (mutates the flow graph)
192 if (FLAG_use_inlining) { 192 if (FLAG_use_inlining) {
193 FlowGraphInliner inliner(flow_graph); 193 FlowGraphInliner inliner(flow_graph);
194 inliner.Inline(); 194 inliner.Inline();
195 // Verify that the use lists are still valid. 195 // Verify that the use lists are still valid.
196 DEBUG_ASSERT(flow_graph->ValidateUseLists()); 196 DEBUG_ASSERT(flow_graph->ValidateUseLists());
197 } 197 }
198 198
199 // Propagate types and eliminate more type tests. 199 // Propagate types and eliminate more type tests.
200 FlowGraphTypePropagator propagator(*flow_graph); 200 FlowGraphTypePropagator propagator(flow_graph);
201 propagator.PropagateTypes(); 201 propagator.PropagateTypes();
202 202
203 // Verify that the use lists are still valid. 203 // Verify that the use lists are still valid.
204 DEBUG_ASSERT(flow_graph->ValidateUseLists()); 204 DEBUG_ASSERT(flow_graph->ValidateUseLists());
205 205
206 // Propagate sminess from CheckSmi to phis. 206 // Propagate sminess from CheckSmi to phis.
207 optimizer.PropagateSminess(); 207 optimizer.PropagateSminess();
208 208
209 // Do optimizations that depend on the propagated type information. 209 // Do optimizations that depend on the propagated type information.
210 optimizer.OptimizeComputations(); 210 optimizer.OptimizeComputations();
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 result = isolate->object_store()->sticky_error(); 578 result = isolate->object_store()->sticky_error();
579 isolate->object_store()->clear_sticky_error(); 579 isolate->object_store()->clear_sticky_error();
580 isolate->set_long_jump_base(base); 580 isolate->set_long_jump_base(base);
581 return result.raw(); 581 return result.raw();
582 } 582 }
583 UNREACHABLE(); 583 UNREACHABLE();
584 return Object::null(); 584 return Object::null();
585 } 585 }
586 586
587 } // namespace dart 587 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698