Chromium Code Reviews Chromium Code Reviews
Issue
10909158:
Add support for building targets directly from gyp. (Closed)
DescriptionAdd support for building targets directly from gyp.
A new --build option has been added which can be used to
build configurations directly from gyp. Each generator
has a new method (PerformBuild) which knows how to invoke
the underlying build environment to build a certain
configuration. e.g.
$ gyp hello.gyp --format=ninja --build=Default
This allows gyp call sites to do actual builds without
having to know the exact method for running the underlying
build environment.
The motivation here is to remove the complexity and
duplication involved with building from gyp. Currently
there are several places where gyp is run and then the
underlying build is run right away in all cases. (e.g
the Gyp tests, the buildbots). NaCl and the NaCL SDK
are also about to add two more places where this is
desirable.
Rational for putting this logic in the generators
themselves is that the generator maintainer is best
placed to know how to invoke the build. Also the
details of how to run Foo seem best placed in the
Foo generator (especially if you think of generators
as plugins for gyp).
BUG=
Committed: https://code.google.com/p/gyp/source/detail?r=1499
Patch Set 1 #Patch Set 2 : add msvs #Patch Set 3 : rebase #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #Patch Set 7 : #Patch Set 8 : #
Total comments: 15
Patch Set 9 : fix nits #
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
