Update call to willShowInstallBannerPrompt to remove implicit conversion

Update call to willShowInstallBannerPrompt to remove implicit conversion

This allows an overloaded version of the function to be added to Blink.

BUG=460945
Committed: https://crrev.com/d790473ddf918ca40fbefe3f4e330d0943c83a4b
Cr-Commit-Position: refs/heads/master@{#325530}

[benwells, 2015-04-16 10:06:22]

benwells@chromium.org changed reviewers:
+ thakis@chromium.org

[benwells, 2015-04-16 10:06:22]

FYI this is an initial patch before this blink patch can land:
https://codereview.chromium.org/1089813002/

[Nico, 2015-04-16 16:46:14]

The patch you linked to doesn't add an override. Is the plan to always have an
override, or is this just some transitional thing?

(This patch lgtm, but style guide says "no overrides" so long-term we shouldn't
have them. Having some for a transitional period for 3-step patches is fine
though.)

[benwells, 2015-04-16 22:08:56]

On 2015/04/16 16:46:14, Nico (afk until Mon Apr 20) wrote:
> The patch you linked to doesn't add an override. Is the plan to always have an
> override, or is this just some transitional thing?
> 
> (This patch lgtm, but style guide says "no overrides" so long-term we
shouldn't
> have them. Having some for a transitional period for 3-step patches is fine
> though.)

I probably should have been clearer. The overloaded function (not an override)
is willShowInstallBannerPrompt in WebLocalFrame.h. Yes, it is a transitional
thing, preparation for a 3-step patch (so the initial patch in a 4-step patch, I
guess).

[benwells, 2015-04-16 22:09:03]

The CQ bit was checked by benwells@chromium.org

[Nico, 2015-04-16 22:10:31]

Go ahead and land then :-)

On Thu, Apr 16, 2015 at 3:08 PM, <benwells@chromium.org> wrote:

> On 2015/04/16 16:46:14, Nico (afk until Mon Apr 20) wrote:
>
>> The patch you linked to doesn't add an override. Is the plan to always
>> have an
>> override, or is this just some transitional thing?
>>
>
>  (This patch lgtm, but style guide says "no overrides" so long-term we
>>
> shouldn't
>
>> have them. Having some for a transitional period for 3-step patches is
>> fine
>> though.)
>>
>
> I probably should have been clearer. The overloaded function (not an
> override)
> is willShowInstallBannerPrompt in WebLocalFrame.h. Yes, it is a
> transitional
> thing, preparation for a 3-step patch (so the initial patch in a 4-step
> patch, I
> guess).
>
> https://codereview.chromium.org/1090863002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-04-16 22:12:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090863002/1

[commit-bot: I haz the power, 2015-04-16 22:47:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-16 22:49:21]

Patchset 1 (id:??) landed as
https://crrev.com/d790473ddf918ca40fbefe3f4e330d0943c83a4b
Cr-Commit-Position: refs/heads/master@{#325530}