Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1090853002: [Password manager tests automation] Fix yahoo website tests. (Closed)

Created:
5 years, 8 months ago by melandory
Modified:
5 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_runner_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests automation] Fix yahoo website tests. Yahoo had wrong username and password field ids and click button action. BUG=369521 R=vabr@chromium.org Committed: https://crrev.com/d58ba2577c30191fbcfcfe4756de20a175e61c34 Cr-Commit-Position: refs/heads/master@{#325418}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/test/data/password_manager/automated_tests/tests.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
melandory
5 years, 8 months ago (2015-04-16 09:17:10 UTC) #1
vabr (Chromium)
LGTM, Thanks for fixing! (I'm looking at the other CL of yours as well, just ...
5 years, 8 months ago (2015-04-16 09:23:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090853002/20001
5 years, 8 months ago (2015-04-16 09:25:20 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 11:49:59 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 11:52:03 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d58ba2577c30191fbcfcfe4756de20a175e61c34
Cr-Commit-Position: refs/heads/master@{#325418}

Powered by Google App Engine
This is Rietveld 408576698