Issue 10908279: Schedule an APC to trigger the thread cap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908279: Schedule an APC to trigger the thread cap (Closed)

Created:
8 years, 3 months ago by jschuh

Modified:
8 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Schedule an APC to trigger the thread cap The loader eats our exceptions during the attach, so we need to schedule an APC to trigger an exception after loading is done. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157034

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/app/chrome_exe_main_win.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

8 years, 3 months ago (2012-09-16 00:19:10 UTC) #2

lgtm

http://codereview.chromium.org/10908279/diff/4/chrome/app/chrome_exe_main_win.cc
File chrome/app/chrome_exe_main_win.cc (right):

http://codereview.chromium.org/10908279/diff/4/chrome/app/chrome_exe_main_win...
chrome/app/chrome_exe_main_win.cc:35: static void CALLBACK
CrashProcessCallback(ULONG_PTR) { __debugbreak(); }
move to private

Expand Messages | Collapse Messages