Add define to limit recommended offscreen allocations. This avoids some failures

Add define to limit recommended offscreen allocations. This avoids some failures
where our out-of-memory handlers do not kick in properly.

BUG=134626
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156969

[reed1, 2012-09-14 18:26:16]

control https://chromiumcodereview.appspot.com/9361061

[Stephen White, 2012-09-14 21:01:33]

Shouldn't we also be doing bitmap_platform_device_win?

https://codereview.chromium.org/10908266/diff/1/skia/ext/bitmap_platform_devi...
File skia/ext/bitmap_platform_device.h (right):

https://codereview.chromium.org/10908266/diff/1/skia/ext/bitmap_platform_devi...
skia/ext/bitmap_platform_device.h:27: #define
SKIA_EXT_RASTER_DEVICE_ALLOCATION_MAX    (256 * 1024 * 1024)
Just as a reference, canvas's hardcoded limit is 256MPixels, or ~1GB. Maybe we
should do the same?  64Mpixels might be a tad small for desktop (with hidpi and
all).

[reed1, 2012-09-14 21:08:20]

256M or 1G -- they are both guesses. I think we're more up against the practical
2G limit of a 32bit machine. I can change it to 1G for the check-in, but I'd
rather not be on the hook to play the the number after that. It is coded such
that it can be specified in the .gyp file per platform...

[reed1, 2012-09-14 21:09:11]

I will need to re-test, so this won't land until Monday.

[reed1, 2012-09-14 21:10:07]

I will try a separate patch to see if such a technique will fix the crash on
windows (unless this one hasn't landed by that time).

[Stephen White, 2012-09-14 21:13:09]

On 2012/09/14 21:08:20, reed1 wrote:
> 256M or 1G -- they are both guesses. I think we're more up against the
practical
> 2G limit of a 32bit machine. I can change it to 1G for the check-in, but I'd
> rather not be on the hook to play the the number after that. It is coded such
> that it can be specified in the .gyp file per platform...

well, here's an lgtm in case you decide you need to land this quickly.

[reed1, 2012-09-15 02:30:34]

tried 1G, and the SVG test failed.
tried 512M and it passed, so checking in w/ that as a compromise.