Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10908249: Remove windows line ending from repo files (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://github.com/samclegg/nativeclient-sdk.git@master
Visibility:
Public.

Description

Remove windows line ending from repo files. Somehow these files got submitted with win32 line endings. Maybe its not worth fixing? BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1419

Patch Set 1 #

Patch Set 2 : more files with CRLF in source control #

Patch Set 3 : fix copyright headers #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+7422 lines, -7422 lines) Patch
M debugger/base/debug_system.h View 1 chunk +8 lines, -8 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/create_ppapi_platform.py View 1 2 1 chunk +206 lines, -206 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/InstallerResources/install.py View 1 2 1 chunk +193 lines, -193 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/__init__.py View 1 1 chunk +31 lines, -31 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/etree/ElementInclude.py View 1 1 chunk +143 lines, -143 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/etree/ElementPath.py View 1 1 chunk +303 lines, -303 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/etree/ElementTree.py View 1 1 chunk +1668 lines, -1668 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/etree/__init__.py View 1 1 chunk +33 lines, -33 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/third_party/etree/cElementTree.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/xml_patch.py View 1 2 1 chunk +174 lines, -174 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/DependencyParser.cs View 1 chunk +53 lines, -53 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/GCCUtilities.cs View 1 chunk +101 lines, -101 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs View 1 chunk +644 lines, -644 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLib.cs View 1 chunk +161 lines, -161 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs View 1 chunk +195 lines, -195 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/Properties/AssemblyInfo.cs View 1 chunk +38 lines, -38 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/Properties/Resources.Designer.cs View 1 chunk +144 lines, -144 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs View 1 chunk +152 lines, -152 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/AssemblyInfo.cs View 1 chunk +30 lines, -30 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerBase.cs View 1 chunk +239 lines, -239 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerVS.cs View 1 chunk +66 lines, -66 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessInfo.cs View 1 chunk +90 lines, -90 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs View 1 chunk +96 lines, -96 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Strings.Designer.cs View 1 chunk +234 lines, -234 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Utility.cs View 1 chunk +220 lines, -220 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/WebServer.cs View 1 chunk +142 lines, -142 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/TestingProjects/BlankValidSolution/NotNaCl/Program.cs View 1 chunk +14 lines, -14 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ComMessageFilter.cs View 1 chunk +160 lines, -160 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/MockProcessSearcher.cs View 1 chunk +36 lines, -36 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/MockPropertyManager.cs View 1 chunk +117 lines, -117 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PluginDebuggerGDBTest.cs View 1 chunk +398 lines, -398 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PluginDebuggerVSTest.cs View 1 chunk +286 lines, -286 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/Properties/AssemblyInfo.cs View 1 chunk +39 lines, -39 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs View 1 chunk +237 lines, -237 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/TestUtilities.cs View 1 chunk +463 lines, -463 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/WebServerTest.cs View 1 chunk +132 lines, -132 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/check_test_results.py View 1 2 1 chunk +49 lines, -49 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/create_package.py View 1 2 1 chunk +124 lines, -124 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
This change is newlines only.
8 years, 3 months ago (2012-09-18 17:37:21 UTC) #1
Sam Clegg
Added more files to the list. All the python files under "visual_studio" had CRLF line ...
8 years, 3 months ago (2012-09-19 00:17:50 UTC) #2
noelallen1
Revert copyright notice changes. If you are getting a warning with presubmit, we should fix ...
8 years, 3 months ago (2012-09-19 19:47:25 UTC) #3
noelallen1
8 years, 3 months ago (2012-09-19 19:47:47 UTC) #4 
Otherwise LGTM

Powered by Google App Engine
This is Rietveld 408576698