unchecked_malloc() for Skia on OSX.

base/process_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file/namespace contains utility functions for enumerating, ending and
 // computing statistics of processes.
 
 #ifndef BASE_PROCESS_UTIL_H_
 #define BASE_PROCESS_UTIL_H_
 
@@ skipping 838 matching lines @@
 // Restore the default exception handler, setting it to Apple Crash Reporter
 // (ReportCrash).  When forking and execing a new process, the child will
 // inherit the parent's exception ports, which may be set to the Breakpad
 // instance running inside the parent.  The parent's Breakpad instance should
 // not handle the child's exceptions.  Calling RestoreDefaultExceptionHandler
 // in the child after forking will restore the standard exception handler.
 // See http://crbug.com/20371/ for more details.
 void RestoreDefaultExceptionHandler();
 #endif  // defined(OS_MACOSX)
 
+#if defined(OS_MACOSX)
+// Very large images or svg canvases can cause huge mallocs.  Skia
+// does tricks on tcmalloc-based systems to allow malloc to fail with
+// a NULL rather than hit the oom crasher.  This replicates that for
+// OSX.
+// TODO(shess): Weird place to put it, but this is where the OOM
+// killer currently lives.
+BASE_EXPORT void* oom_safe_malloc(size_t size);

[Avi (use Gerrit), 2012/09/13 19:45:54]

I don't like the name "oom safe". While it's safe from the oom killer, it's a
very _unsafe_ call overall. I'd lean towards "unsafe_malloc" or the like.

[Scott Hess - ex-Googler, 2012/09/13 20:04:00]

Well, it's not _unsafe_, per se.  Just against general policy. 
unchecked_malloc()?  original_malloc() or system_malloc() seem kind
implementation-driven, but since this is explicitly a case about avoiding a bit
of our implementation, seems fair.

I suppose it would also be worth putting in a scary comment, like "If you use
this without running it by a few of the OSX developers, your code will be
reverted."

+#endif  // defined(OS_MACOSX)
+
 }  // namespace base
 
 #endif  // BASE_PROCESS_UTIL_H_