Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 10908223: Fix Android ninja sdk build (Closed)

Created:
8 years, 3 months ago by cjhopman
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix Android ninja sdk build For some reason, the way we build jars needs us to specify java_in_dir this way with ninja. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156457

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/base.gyp View 1 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
PTAL
8 years, 3 months ago (2012-09-12 19:42:01 UTC) #1
Yaron
http://codereview.chromium.org/10908223/diff/1/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/10908223/diff/1/base/base.gyp#newcode966 base/base.gyp:966: 'java_in_dir': 'android/java', Please make the change here as well
8 years, 3 months ago (2012-09-12 20:47:00 UTC) #2
jar (doing other things)
https://codereview.chromium.org/10908223/diff/5001/base/base.gyp File base/base.gyp (right): https://codereview.chromium.org/10908223/diff/5001/base/base.gyp#newcode954 base/base.gyp:954: 'android/java/src/org/chromium/base/SystemMessageHandler.java', I'm not a gyp pro... and have not ...
8 years, 3 months ago (2012-09-12 21:12:42 UTC) #3
cjhopman
http://codereview.chromium.org/10908223/diff/5001/base/base.gyp File base/base.gyp (right): http://codereview.chromium.org/10908223/diff/5001/base/base.gyp#newcode954 base/base.gyp:954: 'android/java/src/org/chromium/base/SystemMessageHandler.java', On 2012/09/12 21:12:42, jar wrote: > I'm not ...
8 years, 3 months ago (2012-09-12 22:09:21 UTC) #4
Yaron
lgtm
8 years, 3 months ago (2012-09-12 22:28:22 UTC) #5
jar (doing other things)
lgtm
8 years, 3 months ago (2012-09-12 23:01:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10908223/5001
8 years, 3 months ago (2012-09-12 23:19:24 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 01:44:05 UTC) #8
Change committed as 156457

Powered by Google App Engine
This is Rietveld 408576698