src/trusted/validator_x86/testdata/64/test_alias.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/64/test_alias.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/64/sub-rsp.tf ('k') | src/trusted/validator_x86/testdata/64/test_insts.tf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/64/test_alias.tf

diff --git a/src/trusted/validator_x86/testdata/64/test_alias.hex b/src/trusted/validator_x86/testdata/64/test_alias.tf

similarity index 51%

copy from src/trusted/validator_x86/testdata/64/test_alias.hex

copy to src/trusted/validator_x86/testdata/64/test_alias.tf

index a62bd755f578a606794402586325e8317e6b1f26..df73bbf28a49960ec5ab3492a5acc77a04ba4fdb 100644

--- a/src/trusted/validator_x86/testdata/64/test_alias.hex

+++ b/src/trusted/validator_x86/testdata/64/test_alias.tf

@@ -1,14 +1,25 @@

+BITS: 64

+OUTCOME: invalid

# For background, see:

# http://code.google.com/p/nativeclient/issues/detail?id=2574

# "f6 /0" encoding of TEST. This is what assemblers generate.

-f6 c3 00

+asm: test $0x0,%bl

+hex: f6 c3 00

# "f6 /1" encoding of TEST. This is an alias encoding, which we

# should disallow on the grounds of minimalism.

-f6 cb 00

+hex: f6 cb 00

+nc_out: ERROR: This instruction has been marked illegal by Native Client

# The same applies to the "f7" versions of TEST.

-f7 c3 00 00 00 00

-f7 cb 00 00 00 00

+asm: test $0x0,%ebx

+hex: f7 c3 00 00 00 00

+hex: f7 cb 00 00 00 00

+nc_out: ERROR: This instruction has been marked illegal by Native Client