src/trusted/validator_x86/testdata/64/size_error.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/64/size_error.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/64/shl_alias.tf ('k') | src/trusted/validator_x86/testdata/64/sse.tf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/64/size_error.tf

diff --git a/src/trusted/validator_x86/testdata/64/size_error.hex b/src/trusted/validator_x86/testdata/64/size_error.tf

similarity index 50%

copy from src/trusted/validator_x86/testdata/64/size_error.hex

copy to src/trusted/validator_x86/testdata/64/size_error.tf

index 48b648c0ffb6658ce979e6f8d7abc0910376ec3f..d14a50ba53acf73fbf095f5e9a8001178537e723 100644

--- a/src/trusted/validator_x86/testdata/64/size_error.hex

+++ b/src/trusted/validator_x86/testdata/64/size_error.tf

@@ -1,13 +1,25 @@

+BITS: 64

+OUTCOME: invalid

# The following checks if we catch the use of data 66/Rex.W specifying

# undetermined operand size.

# The following checks that we allow Rex.w.

# 0000000000000000: 48 01 c3 add %rbx, %rax

-48 01 c3

+asm: add %rax,%rbx

+hex: 48 01 c3

# The following checks that we allow data 66.

# 0000000000000003: 66 01 c3 add %bx, %ax

-66 01 c3

+asm: add %ax,%bx

+hex: 66 01 c3

# The following checks that we don't allow Rex.w and data 66

-66 48 01 c3

+hex: 66 48 01 c3

+nc_out: ERROR: Opcode sequence doesn't define a valid x86 instruction

+nc_out: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Native Client

+nc_out: [at +3] ERROR: This instruction has been marked illegal by Native Client

+nc_out: [at +3] ERROR: Illegal assignment to RSP