src/trusted/validator_x86/testdata/64/direct-jump-16.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/64/direct-jump-16.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/64/direct-cond-jump-32.tf ('k') | src/trusted/validator_x86/testdata/64/direct-jump-32.tf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/64/direct-jump-16.tf

diff --git a/src/trusted/validator_x86/testdata/32/direct-jump-16.hex b/src/trusted/validator_x86/testdata/64/direct-jump-16.tf

similarity index 56%

copy from src/trusted/validator_x86/testdata/32/direct-jump-16.hex

copy to src/trusted/validator_x86/testdata/64/direct-jump-16.tf

index d593b8cbd7bdf630e317d3d96b22f6014b773218..c573d22d5988965655060a6aab3a1c6b98dfb48d 100644

--- a/src/trusted/validator_x86/testdata/32/direct-jump-16.hex

+++ b/src/trusted/validator_x86/testdata/64/direct-jump-16.tf

@@ -1,10 +1,18 @@

+BITS: 64

+OUTCOME: invalid

# This file tests how we handle a 16-bit direct jump. In particular, it tests

# whether we actually disallow prefix 66 on the direct jump.

# Define direct (16-bit) jump, which NaCl doesn't allow

-66 e9 01 00

+hex: 66 e9 05 00

+nc_out: ERROR: Opcode sequence doesn't define a valid x86 instruction

+nc_out: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Native Client

# Padding in case the parser of the previous instruction recognizes

# the wrong byte length for the jump constant.

-90 90

+asm: nop; nop; nop; nop

+hex: 90 90 90 90