src/trusted/validator_x86/testdata/32/lock-66-test.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/32/lock-66-test.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/32/load-segment.tf ('k') | src/trusted/validator_x86/testdata/32/lzcnt.tf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/32/lock-66-test.tf

diff --git a/src/trusted/validator_x86/testdata/32/lock-66-test.hex b/src/trusted/validator_x86/testdata/32/lock-66-test.tf

similarity index 53%

copy from src/trusted/validator_x86/testdata/32/lock-66-test.hex

copy to src/trusted/validator_x86/testdata/32/lock-66-test.tf

index 28bd3f542fbf6843deb86fe94d59ddc8cdaf2825..461880b418002bbb2cef73757912ea8d077fa403 100644

--- a/src/trusted/validator_x86/testdata/32/lock-66-test.hex

+++ b/src/trusted/validator_x86/testdata/32/lock-66-test.tf

@@ -1,5 +1,12 @@

+BITS: 32

+OUTCOME: invalid

# Test that we accept prefix "66 0f" but not "0f 66".o

# lock addw $0x1,(%eax) -- good order.

-66 f0 83 00 01

+asm: lock addw $0x1,(%eax)

+hex: 66 f0 83 00 01

# lock addw $0x1,(%eax) -- bad order.

-f0 66 83 00 01

+hex: f0 66 83 00 01

+nc_out: Bad prefix usage