Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/variations/variations_associated_data.h

Issue 1090813005: Add a mechanism to force parameters of a group to a specific value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | components/variations/variations_associated_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_associated_data.h
diff --git a/components/variations/variations_associated_data.h b/components/variations/variations_associated_data.h
index 79f31a31e0516904de7f7a262a785d8742cdefdd..7aac5c9a913f90942f71d10f5ceb8ceeefcf3c26 100644
--- a/components/variations/variations_associated_data.h
+++ b/components/variations/variations_associated_data.h
@@ -113,6 +113,10 @@ bool AssociateVariationParams(const std::string& trial_name,
const std::string& group_name,
const std::map<std::string, std::string>& params);
+// TODO: describe string formating
+// TrialName1.GroupName1.Key1/Value1/TrialName2.GroupName2.Key2/Value2/
Alexei Svitkine (slow) 2015/04/22 15:42:37 How about trial.group.key/value/key/value,trial.gr
Alexei Svitkine (slow) 2015/04/24 16:17:26 (Oops, realise above is inconsistent, meant trial.
danduong 2015/04/24 16:22:08 I'm still confused. do you mean: trial1.group1:k1
Alexei Svitkine (slow) 2015/04/24 16:31:52 Yes, sorry for not being very clear before.
+bool AssociateParamsFromString(const std::string&);
+
// Retrieves the set of key-value |params| for the variation associated with
// the specified field trial, based on its selected group. If the field trial
// does not exist or its selected group does not have any parameters associated
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | components/variations/variations_associated_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698