Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/bots/compiler.py

Issue 1090813002: Don't run cps backend dart2js tests in batch mode (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
diff --git a/tools/bots/compiler.py b/tools/bots/compiler.py
index a784a03ca7cf27c6848ad828d095c548c26e625e..276b19634fcf1f39e94707a700a44162b01ce5f2 100644
--- a/tools/bots/compiler.py
+++ b/tools/bots/compiler.py
@@ -359,7 +359,10 @@ def RunCompilerTests(build_info):
if build_info.checked: test_flags += ['--checked']
if build_info.minified: test_flags += ['--minified']
if build_info.host_checked: test_flags += ['--host-checked']
- if build_info.batch: test_flags += ['--dart2js-batch']
+ # cps backend does not work with batch mode due to the environment variable
+ # setting.
+ if build_info.batch and not build_info.cps_ir:
+ test_flags += ['--dart2js-batch']
if build_info.builder_tag: test_flags += ['--builder-tag=' +
build_info.builder_tag]
if build_info.cps_ir: test_flags += ['--cps-ir']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698