Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Issue 1090803002: X87: Use Cells to check prototype chain validity (disabled by default). (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use Cells to check prototype chain validity (disabled by default). port 0179ec57975c5063bbecd98e11cdda77ddad8996 (r27846). original commit message: The cells are stored on prototypes (in their map's PrototypeInfo). When a prototype object changes its map, then both its own validity cell and those of all "downsstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. BUG= Committed: https://crrev.com/758c5e123b7311ff32d14c4fd79aa72b55ca18df Cr-Commit-Position: refs/heads/master@{#27877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 6 chunks +52 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-16 07:02:01 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-16 09:38:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090803002/1
5 years, 8 months ago (2015-04-16 09:39:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 10:40:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 10:41:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/758c5e123b7311ff32d14c4fd79aa72b55ca18df
Cr-Commit-Position: refs/heads/master@{#27877}

Powered by Google App Engine
This is Rietveld 408576698