Issue 109073004: Roll gyp 1685:1806

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109073004: Roll gyp 1685:1806 (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)

Modified:
7 years ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Roll gyp 1685:1806 Too many updates to summarize them here. BUG=none LOG=n R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18390

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

DBC: please test if this works on Windows (cf. https://code.google.com/p/v8/issues/detail?id=2973)

7 years ago (2013-12-10 12:15:13 UTC) #2

Michael Achenbach

lgtm - assuming windows has been tested. Please keep some pause (>1h) between committing the ...

7 years ago (2013-12-10 15:19:42 UTC) #3

jochen (gone - plz use gerrit)

confirmed that it works, compiles & passes tests

7 years ago (2013-12-11 13:13:51 UTC) #4

jochen (gone - plz use gerrit)

7 years ago (2013-12-20 13:37:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r18390 (presubmit successful).