Chromium Code Reviews
Help | Chromium Project | Sign in
(103)

Issue 10907263: Make gyp/win32 compatible with upstream ninja. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by iannucci
Modified:
2 years, 10 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Make gyp/win32 compatible with upstream ninja. BUG=147451 Committed: https://code.google.com/p/gyp/source/detail?r=1501

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 chunks +8 lines, -10 lines 0 comments Download
M pylib/gyp/win_tool.py View 1 1 chunk +0 lines, -10 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 9 (0 generated)
scottmg (ooo jul1 to aug6)
https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/win_tool.py File pylib/gyp/win_tool.py (left): https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/win_tool.py#oldcode182 pylib/gyp/win_tool.py:182: def ExecClWrapper(self, arch, depname, *args): fyi, this function is ...
2 years, 10 months ago (2012-09-17 19:25:25 UTC) #1
scottmg (ooo jul1 to aug6)
https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (left): https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/generator/ninja.py#oldcode1426 pylib/gyp/generator/ninja.py:1426: # Template for compile commands mostly shared between compiling ...
2 years, 10 months ago (2012-09-17 19:27:59 UTC) #2
Evan Martin
LGTM I wrote the identical patch locally this weekend while testing this out. It's way ...
2 years, 10 months ago (2012-09-17 19:33:29 UTC) #3
scottmg (ooo jul1 to aug6)
On 2012/09/17 19:33:29, Evan Martin wrote: > LGTM > > I wrote the identical patch ...
2 years, 10 months ago (2012-09-17 19:36:47 UTC) #4
scottmg (ooo jul1 to aug6)
On 2012/09/17 19:36:47, scottmg wrote: > default to -d) er, default to ".d" obviously.
2 years, 10 months ago (2012-09-17 19:38:11 UTC) #5
Evan Martin
On 2012/09/17 19:36:47, scottmg wrote: > I think just leave it, and perhaps add a ...
2 years, 10 months ago (2012-09-17 19:38:47 UTC) #6
scottmg (ooo jul1 to aug6)
On 2012/09/17 19:38:47, Evan Martin wrote: > On 2012/09/17 19:36:47, scottmg wrote: > > I ...
2 years, 10 months ago (2012-09-17 19:45:25 UTC) #7
iannucci
Test fails are due to not having ninja in depot_tools yet. Have another cl for ...
2 years, 10 months ago (2012-09-17 21:53:20 UTC) #8
scottmg (ooo jul1 to aug6)
2 years, 10 months ago (2012-09-18 16:13:20 UTC) #9
Looks like we're good to go on gyp roll now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5