Chromium Code Reviews
Help | Chromium Project | Sign in
(82)

Issue 10907263: Make gyp/win32 compatible with upstream ninja. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by iannucci
Modified:
1 year, 6 months ago
Reviewers:
Evan Martin, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Make gyp/win32 compatible with upstream ninja.

BUG=147451
Committed: https://code.google.com/p/gyp/source/detail?r=1501

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Lint Patch
M pylib/gyp/generator/ninja.py View 1 2 chunks +8 lines, -10 lines 0 comments 0 errors Download
M pylib/gyp/win_tool.py View 1 1 chunk +0 lines, -10 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 9
scottmg
https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/win_tool.py File pylib/gyp/win_tool.py (left): https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/win_tool.py#oldcode182 pylib/gyp/win_tool.py:182: def ExecClWrapper(self, arch, depname, *args): fyi, this function is ...
1 year, 7 months ago #1
scottmg
https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (left): https://chromiumcodereview.appspot.com/10907263/diff/1/pylib/gyp/generator/ninja.py#oldcode1426 pylib/gyp/generator/ninja.py:1426: # Template for compile commands mostly shared between compiling ...
1 year, 7 months ago #2
Evan Martin
LGTM I wrote the identical patch locally this weekend while testing this out. It's way ...
1 year, 7 months ago #3
scottmg
On 2012/09/17 19:33:29, Evan Martin wrote: > LGTM > > I wrote the identical patch ...
1 year, 7 months ago #4
scottmg
On 2012/09/17 19:36:47, scottmg wrote: > default to -d) er, default to ".d" obviously.
1 year, 7 months ago #5
Evan Martin
On 2012/09/17 19:36:47, scottmg wrote: > I think just leave it, and perhaps add a ...
1 year, 7 months ago #6
scottmg
On 2012/09/17 19:38:47, Evan Martin wrote: > On 2012/09/17 19:36:47, scottmg wrote: > > I ...
1 year, 7 months ago #7
iannucci
Test fails are due to not having ninja in depot_tools yet. Have another cl for ...
1 year, 7 months ago #8
scottmg
1 year, 6 months ago #9
Looks like we're good to go on gyp roll now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434