Issue 10907233: Merged r12485, r12486, r12491, r12494, r12495 into trunk branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907233: Merged r12485, r12486, r12491, r12494, r12495 into trunk branch. (Closed)

Created:
8 years, 3 months ago by danno

Modified:
8 years, 3 months ago

Reviewers:
Toon Verwaest, Michael Starzinger, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

Merged r12485, r12486, r12491, r12494, r12495 into trunk branch. Fix edge case of extension with NULL as source string. Fixed CHECK failure in LCodeGen::DoWrapReceiver when --deopt-every-n-times flag is present Correctly initialize regexp global cache. Ensure correct enumeration indices in the dict Fix API check for length of external arrays. BUG=chromium:144649, chromium:148389, chromium:148378, chromium:148376, chromium:148896 R=yangguo@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12514

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -27 lines)			Patch
M	src/api.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+13 lines, -4 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+47 lines, -0 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-148378.js	View	1 chunk	+7 lines, -5 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-148376.js	View	1 chunk	+6 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2012/09/14 12:50:04, danno wrote: LGTM for r12485 and r12491.

8 years, 3 months ago (2012-09-14 13:08:43 UTC) #2

LGTM for r12495.