Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: media/base/pipeline.cc

Issue 10907213: Adjust tsan suppressions for media::Pipeline due to r156011. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comments to code Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index 31ccf58a3978f84a81c9c76e09729b02d7ad5b4a..2cb87f00d3890569af7602262bcffba8c03cf799 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -360,6 +360,8 @@ void Pipeline::OnAudioTimeUpdate(TimeDelta time, TimeDelta max_time) {
if (waiting_for_clock_update_ && time < clock_->Elapsed())
return;
+ // TODO(scherkus): |state_| should only be accessed on pipeline thread, see
+ // http://crbug.com/137973
if (state_ == kSeeking)
return;
@@ -374,6 +376,8 @@ void Pipeline::OnVideoTimeUpdate(TimeDelta max_time) {
if (has_audio_)
return;
+ // TODO(scherkus): |state_| should only be accessed on pipeline thread, see
+ // http://crbug.com/137973
if (state_ == kSeeking)
return;
« no previous file with comments | « no previous file | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698