Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1090703002: Remove IPPET support from Telemetry since we don't use it. (Closed)

Created:
5 years, 8 months ago by aiolos (Not reviewing)
Modified:
5 years, 8 months ago
Reviewers:
sullivan, dtu, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IPPET support from Telemetry since we don't use it. BUG=477436 Committed: https://crrev.com/78ed2b32860144d03e29afe29d8d9d1a4fa54381 Cr-Commit-Position: refs/heads/master@{#325315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -288 lines) Patch
D tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py View 1 chunk +0 lines, -258 lines 0 comments Download
D tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor_unittest.py View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aiolos (Not reviewing)
Since this is removing support, I'd like an LGTM from all of you before proceeding. ...
5 years, 8 months ago (2015-04-15 19:59:57 UTC) #2
nednguyen
LGTM. I love patches with negative code changes!
5 years, 8 months ago (2015-04-15 20:01:47 UTC) #3
dtu
lgtm
5 years, 8 months ago (2015-04-15 20:09:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090703002/1
5 years, 8 months ago (2015-04-15 20:12:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 21:51:30 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:52:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78ed2b32860144d03e29afe29d8d9d1a4fa54381
Cr-Commit-Position: refs/heads/master@{#325315}

Powered by Google App Engine
This is Rietveld 408576698