Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1090693003: Added platform restrictions to bluetooth API documentation (Closed)

Created:
5 years, 8 months ago by François Beaufort
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, armansito
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added platform restrictions to bluetooth API documentation Committed: https://crrev.com/d070127ce8e91d779bd8c1c46f6aaf00b71328f8 Cr-Commit-Position: refs/heads/master@{#325835}

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/Mac OS/OS/g #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
François Beaufort
Hello Benjamin, This CL simply adds a note to the bluetooth and bluetoothSocket API documentation ...
5 years, 8 months ago (2015-04-17 13:50:34 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/1090693003/diff/1/chrome/common/extensions/docs/templates/intros/bluetooth.html File chrome/common/extensions/docs/templates/intros/bluetooth.html (right): https://codereview.chromium.org/1090693003/diff/1/chrome/common/extensions/docs/templates/intros/bluetooth.html#newcode3 chrome/common/extensions/docs/templates/intros/bluetooth.html:3: This API works <b>only on Mac OS X, Windows ...
5 years, 8 months ago (2015-04-17 17:18:45 UTC) #3
not at google - send to devlin
meant to click lgtm as well
5 years, 8 months ago (2015-04-17 17:18:53 UTC) #4
François Beaufort
On 2015/04/17 17:18:53, kalman wrote: > meant to click lgtm as well I've changed Mac ...
5 years, 8 months ago (2015-04-20 13:20:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090693003/20001
5 years, 8 months ago (2015-04-20 13:21:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-20 13:41:38 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 13:42:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d070127ce8e91d779bd8c1c46f6aaf00b71328f8
Cr-Commit-Position: refs/heads/master@{#325835}

Powered by Google App Engine
This is Rietveld 408576698