Replace FX_NEW with new, remove tests in fpdfdoc.

core/src/fpdfdoc/doc_annot.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fpdfapi/fpdf_pageobj.h"
 CPDF_AnnotList::CPDF_AnnotList(CPDF_Page* pPage)
 {
@@ skipping 19 matching lines @@
         if (dwObjNum == 0) {
             dwObjNum = m_pDocument->AddIndirectObject(pDict);
             CPDF_Reference* pAction = CPDF_Reference::Create(m_pDocument, dwObjNum);
             if (pAction == NULL) {
                 break;
             }
             pAnnots->InsertAt(i, pAction);
             pAnnots->RemoveAt(i + 1);
             pDict = pAnnots->GetDict(i);
         }
-        CPDF_Annot* pAnnot = FX_NEW CPDF_Annot(pDict);
-        if (pAnnot == NULL) {
-            break;
-        }
+        CPDF_Annot* pAnnot = new CPDF_Annot(pDict);
         pAnnot->m_pList = this;
         m_AnnotList.Add(pAnnot);
         if (bRegenerateAP && pDict->GetConstString(FX_BSTRC("Subtype")) == FX_BSTRC("Widget"))
             if (CPDF_InterForm::UpdatingAPEnabled()) {
                 FPDF_GenerateAP(m_pDocument, pDict);
             }
     }
 }
 CPDF_AnnotList::~CPDF_AnnotList()
 {
@@ skipping 164 matching lines @@
 CPDF_Form* CPDF_Annot::GetAPForm(const CPDF_Page* pPage, AppearanceMode mode)
 {
     CPDF_Stream* pStream = FPDFDOC_GetAnnotAP(m_pAnnotDict, mode);
     if (pStream == NULL) {
         return NULL;
     }
     CPDF_Form* pForm;
     if (m_APMap.Lookup(pStream, (void*&)pForm)) {
         return pForm;
     }
-    pForm = FX_NEW CPDF_Form(m_pList->m_pDocument, pPage->m_pResources, pStream);
-    if (pForm == NULL) {
-        return NULL;
-    }
+    pForm = new CPDF_Form(m_pList->m_pDocument, pPage->m_pResources, pStream);
     pForm->ParseContent(NULL, NULL, NULL, NULL);
     m_APMap.SetAt(pStream, pForm);
     return pForm;
 }
 static CPDF_Form* FPDFDOC_Annot_GetMatrix(const CPDF_Page* pPage, CPDF_Annot* pAnnot, CPDF_Annot::AppearanceMode mode, const CFX_AffineMatrix* pUser2Device, CFX_Matrix &matrix)
 {
     CPDF_Form* pForm = pAnnot->GetAPForm(pPage, mode);
     if (!pForm) {
         return NULL;
     }
@@ skipping 74 matching lines @@
         return NULL;
     }
     CPDF_Array* pColor = m_pAnnotDict->GetArray("C");
     FX_DWORD argb = 0xff000000;
     if (pColor != NULL) {
         int R = (FX_INT32)(pColor->GetNumber(0) * 255);
         int G = (FX_INT32)(pColor->GetNumber(1) * 255);
         int B = (FX_INT32)(pColor->GetNumber(2) * 255);
         argb = ArgbEncode(0xff, R, G, B);
     }
-    CPDF_PathObject *pPathObject = FX_NEW CPDF_PathObject();
-    if (!pPathObject) {
-        return NULL;
-    }
+    CPDF_PathObject *pPathObject = new CPDF_PathObject();
     CPDF_GraphStateData *pGraphState = pPathObject->m_GraphState.GetModify();
     if (!pGraphState) {
         pPathObject->Release();
         return NULL;
     }
     pGraphState->m_LineWidth = width;
     CPDF_ColorStateData *pColorData = pPathObject->m_ColorState.GetModify();
     if (!pColorData) {
         pPathObject->Release();
         return NULL;
@@ skipping 171 matching lines @@
         if (pIRT != m_pAnnotDict) {
             continue;
         }
         if (count == index) {
             return pAnnot;
         }
         count ++;
     }
     return NULL;
 }