Alternative Multi-dimensional Rappor

components/rappor/rappor_service.h

Index: components/rappor/rappor_service.h
diff --git a/components/rappor/rappor_service.h b/components/rappor/rappor_service.h
index d50b91e9ca2edda4878a7314e5344b94e16e6c7d..73ad832fc16d7950eb6f70957ba77c2ca08824c2 100644
--- a/components/rappor/rappor_service.h
+++ b/components/rappor/rappor_service.h
@@ -15,6 +15,8 @@
 #include "base/timer/timer.h"
 #include "components/metrics/daily_event.h"
 #include "components/rappor/rappor_parameters.h"
+#include "components/rappor/sample.h"
+#include "components/rappor/sampler.h"
 
 class PrefRegistrySimple;
 class PrefService;
@@ -73,6 +75,11 @@ class RapporService {
   // provided PrefRegistry. This should be called before calling Start().
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
+  scoped_ptr<Sample> MakeSampleObj(RapporType);

[Alexei Svitkine (slow), 2015/04/23 21:42:34]

I don't think we should use "SampleObj" in the signature. How about
CreateSample() and RecordSample(). Also, these methods need documentation -
should be above the static function above.

[Steven Holte, 2015/04/24 16:59:05]

Renamed to CreateSampleObj, but RecordSample is already used by the string
recording function.  It probably makes sense to rename that to RecordString, but
that would require changing a bunch of callers.

+
+  void RecordSampleObj(const std::string& metric_name,
+                       scoped_ptr<Sample> sample);
+
  protected:
   // Initializes the state of the RapporService.
   void InitializeInternal(scoped_ptr<LogUploaderInterface> uploader,
@@ -141,6 +148,8 @@ class RapporService {
   // The map owns the metrics it contains.
   std::map<std::string, RapporMetric*> metrics_map_;
 
+  internal::Sampler sampler_;
+
   DISALLOW_COPY_AND_ASSIGN(RapporService);
 };