Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1090613006: fix #155, numeric integer literals (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M lib/src/js/nodes.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + test/codegen/expect/misc.js View 1 chunk +5 lines, -2 lines 0 comments Download
A test/codegen/expect/misc.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + test/codegen/misc.dart View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 8 months ago (2015-04-23 20:08:48 UTC) #2
Jacob
lgtm https://codereview.chromium.org/1090613006/diff/1/lib/src/js/nodes.dart File lib/src/js/nodes.dart (right): https://codereview.chromium.org/1090613006/diff/1/lib/src/js/nodes.dart#newcode1096 lib/src/js/nodes.dart:1096: * Make sure to generate `(1).toString()` and `1.0.toString()`. ...
5 years, 8 months ago (2015-04-23 20:18:54 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1090613006/diff/1/lib/src/js/nodes.dart File lib/src/js/nodes.dart (right): https://codereview.chromium.org/1090613006/diff/1/lib/src/js/nodes.dart#newcode1096 lib/src/js/nodes.dart:1096: * Make sure to generate `(1).toString()` and `1.0.toString()`. In ...
5 years, 8 months ago (2015-04-23 20:38:52 UTC) #4
Jennifer Messerly
5 years, 8 months ago (2015-04-23 20:43:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db199676bd9bc0a32514c574f36a97b6a0c79a06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698