Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090563002: Reland "Wrap typed array implementations in functions." (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Wrap typed array implementations in functions." R=mvstanton@chromium.org Committed: https://crrev.com/dd06f905cb4d343a0ad9ac063f53aa90eea28883 Cr-Commit-Position: refs/heads/master@{#27839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -122 lines) Patch
M src/array-iterator.js View 2 chunks +53 lines, -53 lines 0 comments Download
M src/arraybuffer.js View 3 chunks +23 lines, -21 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-iterator.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/typedarray.js View 6 chunks +36 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 8 months ago (2015-04-15 09:56:28 UTC) #1
mvstanton
lgtm
5 years, 8 months ago (2015-04-15 10:20:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090563002/1
5 years, 8 months ago (2015-04-15 10:22:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 10:36:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd06f905cb4d343a0ad9ac063f53aa90eea28883 Cr-Commit-Position: refs/heads/master@{#27839}
5 years, 8 months ago (2015-04-15 10:36:45 UTC) #6
Michael Achenbach
On 2015/04/15 10:36:45, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 8 months ago (2015-04-15 18:39:40 UTC) #7
Yang
5 years, 8 months ago (2015-04-16 06:16:36 UTC) #8
Message was sent while issue was closed. 
On 2015/04/15 18:39:40, Michael Achenbach wrote:
> On 2015/04/15 10:36:45, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/dd06f905cb4d343a0ad9ac063f53aa90eea28883
> > Cr-Commit-Position: refs/heads/master@{#27839}
> 
> Any chance this is still coming from this CL?
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...

I can't rule that out 100%, but I don't think that's the case. I haven't been
able to reproduce them locally and it generally seems unrelated. Changing native
JS implementation should hardly interfere with locking.

Powered by Google App Engine
This is Rietveld 408576698