Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1090553004: Move gn build file for sfntly from secondary tree into the main tree. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, arthurhsu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gn build file for sfntly from secondary tree into the main tree. Better to keep it side-by-side with the gyp file which is also in the main tree. BUG=None TEST=gn gen out-gn && ninja -C out-gn sfntly still works R=vandebo@chromium.org,dpranke@chromium.org Committed: https://crrev.com/3af9f401d955a957527d0a913736e48dcacb67a7 Cr-Commit-Position: refs/heads/master@{#326121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -130 lines) Patch
D build/secondary/third_party/sfntly/BUILD.gn View 1 chunk +0 lines, -131 lines 0 comments Download
A + third_party/sfntly/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
PTAL!
5 years, 8 months ago (2015-04-20 21:51:25 UTC) #1
vandebo (ex-Chrome)
Arthur may be able to review, or know a better reviewer.
5 years, 8 months ago (2015-04-20 21:53:37 UTC) #3
arthurhsu
On 2015/04/20 21:53:37, vandebo (ex-Chrome) wrote: > Arthur may be able to review, or know ...
5 years, 8 months ago (2015-04-20 22:29:05 UTC) #4
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-21 20:37:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090553004/1
5 years, 8 months ago (2015-04-21 21:15:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 21:20:48 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 21:21:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3af9f401d955a957527d0a913736e48dcacb67a7
Cr-Commit-Position: refs/heads/master@{#326121}

Powered by Google App Engine
This is Rietveld 408576698