Issue 10905317: Generic containers moved into a separate module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905317: Generic containers moved into a separate module (Closed)

Created:
8 years, 3 months ago by Petr Hosek

Modified:
8 years, 2 months ago

Reviewers:
bsy, Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Generic containers moved into a separate module, split each container into individual source file. The tests will be provided in the follow up change list as a part of larger refactoring. BUG= TESTS=trybots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10006

Patch Set 1 : Removed unused files. #

Patch Set 2 : Removed (unused) service runtime reference. #

Patch Set 3 : Rebased with master. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+292 lines, -927 lines)			Patch
M	SConstruct	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	site_scons/site_tools/library_deps.py	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A +	src/trusted/generic_container/build.scons	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
A +	src/trusted/generic_container/container.h	View		3 chunks	+5 lines, -85 lines	0 comments	Download
A	src/trusted/generic_container/container_hash_table.h	View		1 chunk	+61 lines, -0 lines	0 comments	Download
A +	src/trusted/generic_container/container_hash_table.c	View		1 chunk	+2 lines, -157 lines	0 comments	Download
A	src/trusted/generic_container/container_list.h	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	src/trusted/generic_container/container_list.c	View		1 chunk	+158 lines, -0 lines	0 comments	Download
A +	src/trusted/generic_container/generic_container.gyp	View		3 chunks	+10 lines, -12 lines	0 comments	Download
M	src/trusted/service_runtime/build.scons	View	1 2	2 chunks	+0 lines, -5 lines	0 comments	Download
D	src/trusted/service_runtime/generic_container/container.h	View		1 chunk	+0 lines, -178 lines	0 comments	Download
D	src/trusted/service_runtime/generic_container/container.c	View		1 chunk	+0 lines, -471 lines	0 comments	Download
M	src/trusted/service_runtime/service_runtime.gyp	View	1 2	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm if lgt bots

Expand Messages | Collapse Messages