Consolidate bubble border code.

ui/app_list/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/app_list_view.h"
 
 #include "base/string_util.h"
-#include "ui/app_list/app_list_bubble_border.h"
+#include "ui/app_list/app_list_background.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_item_view.h"
 #include "ui/app_list/app_list_model.h"
 #include "ui/app_list/app_list_view_delegate.h"
 #include "ui/app_list/contents_view.h"
 #include "ui/app_list/pagination_model.h"
 #include "ui/app_list/search_box_model.h"
 #include "ui/app_list/search_box_view.h"
 #include "ui/base/events/event.h"
 #include "ui/gfx/insets.h"
+#include "ui/gfx/path.h"
+#include "ui/gfx/skia_util.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/widget/widget.h"
 
 namespace app_list {
 
 namespace {
 
 // Inner padding space in pixels of bubble contents.
 const int kInnerPadding = 1;
 
 // The distance between the arrow tip and edge of the anchor view.
 const int kArrowOffset = 10;
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListView:
 
 AppListView::AppListView(AppListViewDelegate* delegate)
     : delegate_(delegate),
-      bubble_border_(NULL),
       search_box_view_(NULL),
       contents_view_(NULL) {
 }
 
 AppListView::~AppListView() {
   // Deletes all child views while the models are still valid.
   RemoveAllChildViews(true);
 }
 
 void AppListView::InitAsBubble(
@@ skipping 17 matching lines @@
   search_box_view_ = new SearchBoxView(this);
   AddChildView(search_box_view_);
 
   contents_view_ = new ContentsView(this, pagination_model);
   AddChildView(contents_view_);
 
   search_box_view_->set_contents_view(contents_view_);
 
   set_anchor_view(anchor);
   set_anchor_point(anchor_point);
+  set_color(kContentsBackgroundColor);
   set_margins(gfx::Insets());
   set_move_with_anchor(true);
   set_parent_window(parent);
   set_close_on_deactivate(false);
-  set_anchor_insets(gfx::Insets(kArrowOffset, kArrowOffset, kArrowOffset,
-      kArrowOffset));
+  // Shift anchor rect up 1px because app menu icon center is 1px above anchor
+  // rect center when shelf is on left/right.
+  set_anchor_insets(gfx::Insets(kArrowOffset - 1, kArrowOffset,
+                                kArrowOffset + 1, kArrowOffset));
+  set_shadow(views::BubbleBorder::BIG_SHADOW);
   views::BubbleDelegateView::CreateBubble(this);
-
-  // Overrides border with AppListBubbleBorder.
-  bubble_border_ = new AppListBubbleBorder(this, search_box_view_);
-  GetBubbleFrameView()->SetBubbleBorder(bubble_border_);
   SetBubbleArrowLocation(arrow_location);
 
 #if !defined(OS_WIN)
-  // Resets default background since AppListBubbleBorder paints background.
-  GetBubbleFrameView()->set_background(NULL);
+  GetBubbleFrameView()->set_background(new AppListBackground(
+      GetBubbleFrameView()->bubble_border()->GetBorderCornerRadius(),
+      search_box_view_));
 
   contents_view_->SetPaintToLayer(true);
   contents_view_->SetFillsBoundsOpaquely(false);
   contents_view_->layer()->SetMasksToBounds(true);
 #endif
 
   CreateModel();
 }
 
 void AppListView::SetBubbleArrowLocation(
     views::BubbleBorder::ArrowLocation arrow_location) {
-  DCHECK(bubble_border_);
-  bubble_border_->set_arrow_location(arrow_location);
+  GetBubbleFrameView()->bubble_border()->set_arrow_location(arrow_location);
   SizeToContents();  // Recalcuates with new border.
+  GetBubbleFrameView()->SchedulePaint();
 }
 
 void AppListView::Close() {
   if (delegate_.get())
     delegate_->Close();
   else
     GetWidget()->Close();
 }
 
 void AppListView::UpdateBounds() {
@@ skipping 23 matching lines @@
 
   return gfx::ImageSkia();
 }
 
 bool AppListView::HasHitTestMask() const {
   return true;
 }
 
 void AppListView::GetHitTestMask(gfx::Path* mask) const {
   DCHECK(mask);
-  bubble_border_->GetMask(GetBubbleFrameView()->bounds(), mask);
+  mask->addRect(gfx::RectToSkRect(
+      GetBubbleFrameView()->GetContentsBounds()));
 }
 
 bool AppListView::OnKeyPressed(const ui::KeyEvent& event) {
   if (event.key_code() == ui::VKEY_ESCAPE) {
     Close();
     return true;
   }
 
   return false;
 }
 
 void AppListView::ButtonPressed(views::Button* sender, const ui::Event& event) {
   if (sender->GetClassName() != AppListItemView::kViewClassName)
     return;
 
   if (delegate_.get()) {
     delegate_->ActivateAppListItem(
         static_cast<AppListItemView*>(sender)->model(),
         event.flags());
   }
   Close();
 }
 
-gfx::Rect AppListView::GetBubbleBounds() {
-  // This happens before replacing the default border.
-  if (!bubble_border_)
-    return views::BubbleDelegateView::GetBubbleBounds();
-
-  const gfx::Rect anchor_rect = GetAnchorRect();
-  gfx::Rect bubble_rect = GetBubbleFrameView()->GetUpdatedWindowBounds(
-      anchor_rect,
-      GetPreferredSize(),
-      false /* try_mirroring_arrow */);
-
-  const gfx::Point old_offset = bubble_border_->offset();
-  bubble_rect = bubble_border_->ComputeOffsetAndUpdateBubbleRect(bubble_rect,
-      anchor_rect);
-
-  // Repaints border if arrow offset is changed.
-  if (bubble_border_->offset() != old_offset)
-    GetBubbleFrameView()->SchedulePaint();
-
-  return bubble_rect;
-}
-
 void AppListView::QueryChanged(SearchBoxView* sender) {
   string16 query;
   TrimWhitespace(model_->search_box()->text(), TRIM_ALL, &query);
   bool should_show_search = !query.empty();
   contents_view_->ShowSearchResults(should_show_search);
 
   if (delegate_.get()) {
     if (should_show_search)
       delegate_->StartSearch();
     else
       delegate_->StopSearch();
   }
 }
 
 void AppListView::OpenResult(const SearchResult& result, int event_flags) {
   if (delegate_.get())
     delegate_->OpenSearchResult(result, event_flags);
 }
 
 void AppListView::InvokeResultAction(const SearchResult& result,
                                      int action_index,
                                      int event_flags) {
   if (delegate_.get())
     delegate_->InvokeSearchResultAction(result, action_index, event_flags);
 }
 
 }  // namespace app_list