Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: lib/compiler/implementation/dart_backend/backend.dart

Issue 10905305: Patch refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Replaced includeInjectedMembers by implementation Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/dart_backend/backend.dart
diff --git a/lib/compiler/implementation/dart_backend/backend.dart b/lib/compiler/implementation/dart_backend/backend.dart
index 0f9ec2b54a12308d9798526044d4b42cdb481b2d..e0797df72cde8e96e076c78cabeb2c411969737d 100644
--- a/lib/compiler/implementation/dart_backend/backend.dart
+++ b/lib/compiler/implementation/dart_backend/backend.dart
@@ -200,7 +200,9 @@ class DartBackend extends Backend {
final fixedMemberNames = new Set<String>();
for (final library in compiler.libraries.getValues()) {
if (!library.isPlatformLibrary) continue;
- for (final element in library.localMembers) {
+ // TODO(johnniwinther): Should we use the implementation element to
+ // include injected members?
ahe 2012/10/02 13:27:04 Yes
Johnni Winther 2012/10/03 09:22:59 Done.
+ library.forEachLocalMember((Element element) {
if (element is ClassElement) {
ClassElement classElement = element;
for (final member in classElement.localMembers) {
@@ -215,7 +217,7 @@ class DartBackend extends Backend {
} else {
fixedMemberNames.add(element.name.slowToString());
}
- }
+ });
}
// TODO(antonm): TypeError.srcType and TypeError.dstType are defined in
// runtime/lib/error.dart. Overall, all DartVM specific libs should be

Powered by Google App Engine
This is Rietveld 408576698