Switch primary display

Add switch primary display option by swapping primary root window between displays.
This has following sub-changes
- DisplayController now manages which display is primary display, instead of relying on the order in DisplayManager
- MultiDisplayManager uses display ID instead of order to
  check if a display has added/removed or its bounds has change. (which is fixes the TODO)
- Primary display always has 0,0 origin.

This also fixed a few issues that i discovered while working on this.
- RootWindowHostLinux::SetBounds causes 2 ConfigureNotify, which causes unnecessary move/resize
  event.
- mouse_cursor_event_filter and display_controller were using default_display_layout, which is wrong. It should use the layout for currently used secondary display.

BUG=146886
TEST=covered by test. On device, press alt-f4 to switch primary display.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157492

[sky, 2012-09-18 03:52:47]

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
File ash/display/display_controller.cc (right):

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
ash/display/display_controller.cc:73: default:
remove default and put NOTREACHED outside of switch so you get compile errors if
another enum value is added.

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
ash/display/display_controller.cc:119: default:
Saem comment as line 73 above.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
File ash/display/multi_display_manager.cc (right):

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:146: if (updated_displays.size() == 0) {
empty

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:186: DisplayList::iterator curr_iter =
displays_.begin();
move iterators into for loop.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:221: // being removed are accessed during
shutting the root.
shutting down the root

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:235: displays_.erase(displays_.end());
Don't you need displays_.end() - 1?

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
File ash/display/multi_display_manager.h (right):

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.h:49: // When set to ture, the
MultiMonitorManager calls OnDisplayBoundsChanged
true

[oshima, 2012-09-18 09:30:48]

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
File ash/display/display_controller.cc (right):

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
ash/display/display_controller.cc:73: default:
On 2012/09/18 03:52:47, sky wrote:
> remove default and put NOTREACHED outside of switch so you get compile errors
if
> another enum value is added.

Done.

http://codereview.chromium.org/10905288/diff/16001/ash/display/display_contro...
ash/display/display_controller.cc:119: default:
On 2012/09/18 03:52:47, sky wrote:
> Saem comment as line 73 above.

Done.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
File ash/display/multi_display_manager.cc (right):

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:146: if (updated_displays.size() == 0) {
On 2012/09/18 03:52:47, sky wrote:
> empty

Done.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:186: DisplayList::iterator curr_iter =
displays_.begin();
On 2012/09/18 03:52:47, sky wrote:
> move iterators into for loop.

Done.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:221: // being removed are accessed during
shutting the root.
On 2012/09/18 03:52:47, sky wrote:
> shutting down the root

Done.

http://codereview.chromium.org/10905288/diff/16001/ash/display/multi_display_...
ash/display/multi_display_manager.cc:235: displays_.erase(displays_.end());
On 2012/09/18 03:52:47, sky wrote:
> Don't you need displays_.end() - 1?

I should have used pop_back()

http://codereview.chromium.org/10905288/diff/22002/ash/display/display_contro...
File ash/display/display_controller.cc (right):

http://codereview.chromium.org/10905288/diff/22002/ash/display/display_contro...
ash/display/display_controller.cc:202: if (primary_display_.id() !=
display->id()) {
I fixed this after your review. PTL

http://codereview.chromium.org/10905288/diff/22002/ash/display/display_contro...
File ash/display/display_controller.h (right):

http://codereview.chromium.org/10905288/diff/22002/ash/display/display_contro...
ash/display/display_controller.h:135: const DisplayLayout&
GetCurrentDisplayLayout() const;
I noticed that I was mistakenly using default_layout as a layout for secondary
display. I added this method to replace such use (mouse_cursor_event_filter and
display_controller)

http://codereview.chromium.org/10905288/diff/22002/ash/shell.cc
File ash/shell.cc (left):

http://codereview.chromium.org/10905288/diff/22002/ash/shell.cc#oldcode199
ash/shell.cc:199:
aura::Env::GetInstance()->display_manager())->InitInternalDisplayInfo();
I moved this to MultiDisplayManager's constructor.

[oshima, 2012-09-18 15:32:09]

forgot to add.

http://codereview.chromium.org/10905288/diff/27001/ui/aura/root_window_host_l...
File ui/aura/root_window_host_linux.cc (right):

http://codereview.chromium.org/10905288/diff/27001/ui/aura/root_window_host_l...
ui/aura/root_window_host_linux.cc:43: #include "base/debug/stack_trace.h"
i'll remove this.

http://codereview.chromium.org/10905288/diff/27001/ui/aura/root_window_host_l...
ui/aura/root_window_host_linux.cc:768: XConfigureWindow(xdisplay_, xwindow_,
value_mask, &changes);
This fixed two configure event issue.

[sky, 2012-09-18 18:11:09]

LGTM

[commit-bot: I haz the power, 2012-09-18 19:26:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10905288/21028

[commit-bot: I haz the power, 2012-09-18 21:09:10]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-09-19 00:05:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10905288/13012

[commit-bot: I haz the power, 2012-09-19 00:05:41]

Failed to apply patch for ash/display/display_controller.cc:
While running patch -p1 --forward --force;
patching file ash/display/display_controller.cc
Hunk #12 FAILED at 444.
Hunk #13 succeeded at 459 (offset -1 lines).
1 out of 13 hunks FAILED -- saving rejects to file
ash/display/display_controller.cc.rej

[commit-bot: I haz the power, 2012-09-19 00:42:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10905288/16007