Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: pkg/dartdoc/bin/dartdoc.dart

Issue 10905276: Remove unneeded _IN_SDK stuff in dartdoc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/create_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/bin/dartdoc.dart
diff --git a/pkg/dartdoc/bin/dartdoc.dart b/pkg/dartdoc/bin/dartdoc.dart
index bdcec0c8136b2b71dc670bf25f87d9f22fe906b8..662b62309286b408c5eff3c0a724735fc469d346 100644
--- a/pkg/dartdoc/bin/dartdoc.dart
+++ b/pkg/dartdoc/bin/dartdoc.dart
@@ -21,18 +21,6 @@
// TODO(rnystrom): Use "package:" URL (#4968).
#import('../lib/dartdoc.dart');
-// TODO(johnniwinther): Note that [IN_SDK] gets initialized to true when this
-// file is modified by the SDK deployment script. If you change, be sure to test
-// that dartdoc still works when run from the built SDK directory.
-const bool _IN_SDK = false;
-
-// TODO(johnniwinther): Trailing slashes matter due to the use of [libPath] as
-// a base URI with [Uri.resolve].
-/// Relative path to the library in which dart2js resides.
-Path get libPath => _IN_SDK
- ? scriptDir.append('../../../lib/dart2js/')
- : scriptDir.append('../../../');
-
/**
* Run this from the `pkg/dartdoc` directory.
*/
@@ -40,6 +28,8 @@ main() {
final args = new Options().arguments;
final dartdoc = new Dartdoc();
+
+ final libPath = scriptDir.append('../../../');
dartdoc.dartdocPath = libPath.append('pkg/dartdoc');
if (args.isEmpty()) {
« no previous file with comments | « no previous file | tools/create_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698