Tweaking the "insecure CSP" error message to clarify that both 'script-src' and 'object-src' must b…

Tweaking the "insecure CSP" error message to clarify that both 'script-src' and 'object-src' must be set.

As a drive-by, it also updates the documentation to correct a typo in one of the examples, ensuring that both directives are properly set.

BUG=148919
R=aa@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156781

[Mike West, 2012-09-13 10:02:16]

Hi Aaron! Would you mind taking a look at this CL?

-mike

[Aaron Boodman, 2012-09-13 15:53:36]

lgtm w/ nits

http://codereview.chromium.org/10905258/diff/1002/chrome/common/extensions/ex...
File chrome/common/extensions/extension_manifest_constants.cc (right):

http://codereview.chromium.org/10905258/diff/1002/chrome/common/extensions/ex...
chrome/common/extensions/extension_manifest_constants.cc:465: "
\"chrome-extension://\" origin. For more information, see"
You can whitelist unsafe-eval too, right?

[Mike West, 2012-09-13 22:44:13]

On 2012/09/13 15:53:36, Aaron Boodman wrote:
> lgtm w/ nits

Nit: Drop the pluralization. ;)

Good eye. I've added 'unsafe-eval' to the log message. I'll throw it in the
queue.

[commit-bot: I haz the power, 2012-09-13 22:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/10905258/7001

[commit-bot: I haz the power, 2012-09-13 23:14:22]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-14 08:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/10905258/2002

[commit-bot: I haz the power, 2012-09-14 11:22:33]

Change committed as 156781