Introduce PPB_Flash_Font.

Introduce PPB_Flash_Font.

It is a subset of PPB_PDF and shares the implementation with some PPB_PDF methods. With this interface, Pepper Flash doesn't need to depend on PPB_PDF.

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160861

[yzshen1, 2012-09-12 00:07:22]

Hi, Brett.

Would you please take a look? Thanks!

[brettw, 2012-09-13 23:10:41]

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/api/private/p...
File ppapi/api/private/ppb_flash_font.idl (right):

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/api/private/p...
ppapi/api/private/ppb_flash_font.idl:14: interface PPB_Flash_Font {
Can you call this PPB_Flash_FontFile?

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/api/private/p...
ppapi/api/private/ppb_flash_font.idl:20: PP_Resource GetFontFileWithFallback(
Can you just call this "Create"?

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/api/private/p...
ppapi/api/private/ppb_flash_font.idl:28: PP_Bool GetFontTableForPrivateFontFile(
Can you call this GetFontTable?

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/cpp/private/f...
File ppapi/cpp/private/flash_font.h (right):

https://chromiumcodereview.appspot.com/10905227/diff/7001/ppapi/cpp/private/f...
ppapi/cpp/private/flash_font.h:17: class Font {
Can you just make this a regular resource called FontFile with a constructor
instead of GetFontFileWIthFallback and one member function get the table?

[yzshen1, 2012-10-08 18:38:00]

Hi, Brett.

Would you please take another look?
This CL has been mostly rewritten to use the new host/proxy framework.

Thanks!

http://codereview.chromium.org/10905227/diff/7001/ppapi/api/private/ppb_flash...
File ppapi/api/private/ppb_flash_font.idl (right):

http://codereview.chromium.org/10905227/diff/7001/ppapi/api/private/ppb_flash...
ppapi/api/private/ppb_flash_font.idl:14: interface PPB_Flash_Font {
On 2012/09/13 23:10:41, brettw wrote:
> Can you call this PPB_Flash_FontFile?

Done.

http://codereview.chromium.org/10905227/diff/7001/ppapi/api/private/ppb_flash...
ppapi/api/private/ppb_flash_font.idl:20: PP_Resource GetFontFileWithFallback(
On 2012/09/13 23:10:41, brettw wrote:
> Can you just call this "Create"?

Done.

http://codereview.chromium.org/10905227/diff/7001/ppapi/api/private/ppb_flash...
ppapi/api/private/ppb_flash_font.idl:28: PP_Bool GetFontTableForPrivateFontFile(
On 2012/09/13 23:10:41, brettw wrote:
> Can you call this GetFontTable?

Done.

http://codereview.chromium.org/10905227/diff/7001/ppapi/cpp/private/flash_font.h
File ppapi/cpp/private/flash_font.h (right):

http://codereview.chromium.org/10905227/diff/7001/ppapi/cpp/private/flash_fon...
ppapi/cpp/private/flash_font.h:17: class Font {
On 2012/09/13 23:10:41, brettw wrote:
> Can you just make this a regular resource called FontFile with a constructor
> instead of GetFontFileWIthFallback and one member function get the table?

Done.

[brettw, 2012-10-08 22:44:45]

lgtm

http://codereview.chromium.org/10905227/diff/19001/ppapi/cpp/private/flash_fo...
File ppapi/cpp/private/flash_font_file.cc (right):

http://codereview.chromium.org/10905227/diff/19001/ppapi/cpp/private/flash_fo...
ppapi/cpp/private/flash_font_file.cc:19: template <> const char*
interface_name<PPB_PDF>() {
I think we usually skip the space after "template"

[yzshen1, 2012-10-08 23:09:07]

http://codereview.chromium.org/10905227/diff/19001/ppapi/cpp/private/flash_fo...
File ppapi/cpp/private/flash_font_file.cc (right):

http://codereview.chromium.org/10905227/diff/19001/ppapi/cpp/private/flash_fo...
ppapi/cpp/private/flash_font_file.cc:19: template <> const char*
interface_name<PPB_PDF>() {
On 2012/10/08 22:44:45, brettw wrote:
> I think we usually skip the space after "template"
I think we have this space for files in ppapi/cpp.
And I searched both "template <" and "template<". The score is 1935:1771. :)

[commit-bot: I haz the power, 2012-10-09 05:10:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/10905227/23003

[commit-bot: I haz the power, 2012-10-09 05:10:37]

Failed to apply patch for
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
  Hunk #1 FAILED at 3.
  Hunk #3 succeeded at 213 (offset 1 line).
  Hunk #4 succeeded at 2566 (offset 2 lines).
  Hunk #5 succeeded at 3951 (offset 24 lines).
  Hunk #6 succeeded at 4746 (offset 30 lines).
  Hunk #7 succeeded at 4996 (offset 36 lines).
  1 out of 7 hunks FAILED -- saving rejects to file
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c.rej

Patch:       ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
Index: ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
diff --git a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
index
bca2cae5aa075a263d47e87aa3a4d85aec4c1281..afb7506d102e244229419c8201b71f7361d0db34
100644
--- a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
+++ b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
@@ -3,7 +3,7 @@
  * found in the LICENSE file.
  */
 
-/* Last generated from IDL: Fri Oct  5 16:24:42 2012. */
+/* Last generated from IDL: Mon Oct  8 16:28:58 2012. */
 #include "ppapi/generators/pnacl_shim.h"
 
 #include "ppapi/c/ppb.h"
@@ -70,6 +70,7 @@
 #include "ppapi/c/private/ppb_flash.h"
 #include "ppapi/c/private/ppb_flash_clipboard.h"
 #include "ppapi/c/private/ppb_flash_device_id.h"
+#include "ppapi/c/private/ppb_flash_font_file.h"
 #include "ppapi/c/private/ppb_flash_fullscreen.h"
 #include "ppapi/c/private/ppb_flash_message_loop.h"
 #include "ppapi/c/private/ppb_flash_print.h"
@@ -211,6 +212,7 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_Flash_12_5;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_Clipboard_3_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_Clipboard_4_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_DeviceID_1_0;
+static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_FontFile_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_FlashFullscreen_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_FlashFullscreen_1_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_MessageLoop_0_1;
@@ -2562,6 +2564,8 @@ int32_t
Pnacl_M21_PPB_Flash_DeviceID_GetDeviceID(PP_Resource device_id, struct P
 
 /* End wrapper methods for PPB_Flash_DeviceID_1_0 */
 
+/* Not generating wrapper methods for PPB_Flash_FontFile_0_1 */
+
 /* Not generating wrapper methods for PPB_FlashFullscreen_0_1 */
 
 /* Not generating wrapper methods for PPB_FlashFullscreen_1_0 */
@@ -3923,6 +3927,8 @@ struct PPB_Flash_DeviceID_1_0
Pnacl_Wrappers_PPB_Flash_DeviceID_1_0 = {
     .GetDeviceID = (int32_t (*)(PP_Resource device_id, struct PP_Var* id,
struct PP_CompletionCallback callback))&Pnacl_M21_PPB_Flash_DeviceID_GetDeviceID
 };
 
+/* Not generating wrapper interface for PPB_Flash_FontFile_0_1 */
+
 /* Not generating wrapper interface for PPB_FlashFullscreen_0_1 */
 
 /* Not generating wrapper interface for PPB_FlashFullscreen_1_0 */
@@ -4710,6 +4716,12 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_Flash_DeviceID_1_0 = {
   .real_iface = NULL
 };
 
+static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Flash_FontFile_0_1 = {
+  .iface_macro = PPB_FLASH_FONTFILE_INTERFACE_0_1,
+  .wrapped_iface = NULL /* Still need slot for real_iface */,
+  .real_iface = NULL
+};
+
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_FlashFullscreen_0_1 = {
   .iface_macro = PPB_FLASHFULLSCREEN_INTERFACE_0_1,
   .wrapped_iface = NULL /* Still need slot for real_iface */,
@@ -4948,6 +4960,7 @@ static struct __PnaclWrapperInfo *s_ppb_wrappers[] = {
   &Pnacl_WrapperInfo_PPB_Flash_Clipboard_3_0,
   &Pnacl_WrapperInfo_PPB_Flash_Clipboard_4_0,
   &Pnacl_WrapperInfo_PPB_Flash_DeviceID_1_0,
+  &Pnacl_WrapperInfo_PPB_Flash_FontFile_0_1,
   &Pnacl_WrapperInfo_PPB_FlashFullscreen_0_1,
   &Pnacl_WrapperInfo_PPB_FlashFullscreen_1_0,
   &Pnacl_WrapperInfo_PPB_Flash_MessageLoop_0_1,

[commit-bot: I haz the power, 2012-10-09 05:37:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/10905227/29002

[commit-bot: I haz the power, 2012-10-09 05:38:12]

Presubmit check for 10905227-29002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Missing PPAPI IDL for private interface, please generate IDL:

***************
  ppapi/c/private/ppb_pdf.h
***************

Presubmit checks took 3.6s to calculate.

[yzshen1, 2012-10-09 17:08:59]

For the record, I did run the trybots. But somehow the results were not
reflected on this page.