Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 10905122: Initial NPAPI plugin support in Win Aura. (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Initial NPAPI plugin support in Win Aura. Scrolling jank is noticable because the plugin moves at a different time than the content is updated. There are also a couple of other functions in RenderWidgetHostViewWin that enumerate plugin indows that need to be shared, but I'm leaving these for a future change. The code in render_widget_host_view_base.cc is all moved from render_widget_host_view_win.cc with the exception of the lines between the USE_AURA ifdef. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156090

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : fix mac compile #

Patch Set 7 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -245 lines) Patch
M content/browser/plugin_process_host.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 3 chunks +37 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 5 6 2 chunks +269 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 10 chunks +9 lines, -219 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 2 3 4 5 6 8 chunks +12 lines, -13 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 3 months ago (2012-09-11 14:57:40 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-09-11 15:21:51 UTC) #2
Great! LGTM.

Powered by Google App Engine
This is Rietveld 408576698