Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10905076: Minimal if-def changes for OS_IOS in browser_main_loop.* (Closed)

Created:
8 years, 3 months ago by leng
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
stuartmorgan, chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Minimal if-def changes for OS_IOS in browser_main_loop.* BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155724

Patch Set 1 #

Patch Set 2 : Fixed use of audio_manager_. #

Patch Set 3 : Removed empty line #

Total comments: 2

Patch Set 4 : Combined two if-def blocks into one. #

Patch Set 5 : fixed ordering #

Total comments: 2

Patch Set 6 : Added newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M content/browser/browser_main_loop.h View 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 13 chunks +29 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jam
https://codereview.chromium.org/10905076/diff/3001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/10905076/diff/3001/content/browser/browser_main_loop.cc#newcode341 content/browser/browser_main_loop.cc:341: system_monitor_.reset(new base::SystemMonitor); nit: move this code up so that ...
8 years, 3 months ago (2012-09-05 15:49:05 UTC) #1
leng
https://codereview.chromium.org/10905076/diff/3001/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/10905076/diff/3001/content/browser/browser_main_loop.cc#newcode341 content/browser/browser_main_loop.cc:341: system_monitor_.reset(new base::SystemMonitor); On 2012/09/05 15:49:05, John Abd-El-Malek wrote: > ...
8 years, 3 months ago (2012-09-06 08:40:02 UTC) #2
jam
lgtm https://codereview.chromium.org/10905076/diff/10002/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/10905076/diff/10002/content/browser/browser_main_loop.cc#newcode337 content/browser/browser_main_loop.cc:337: #if !defined(OS_IOS) nit: blank line before this for ...
8 years, 3 months ago (2012-09-06 16:25:45 UTC) #3
leng
https://codereview.chromium.org/10905076/diff/10002/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/10905076/diff/10002/content/browser/browser_main_loop.cc#newcode337 content/browser/browser_main_loop.cc:337: #if !defined(OS_IOS) On 2012/09/06 16:25:45, John Abd-El-Malek wrote: > ...
8 years, 3 months ago (2012-09-06 16:29:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10905076/10006
8 years, 3 months ago (2012-09-06 16:30:12 UTC) #5
commit-bot: I haz the power
Try job failure for 10905076-10006 (retry) on linux_rel for step "interactive_ui_tests" (clobber build). It's a ...
8 years, 3 months ago (2012-09-06 18:22:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10905076/10006
8 years, 3 months ago (2012-09-07 08:23:18 UTC) #7
commit-bot: I haz the power
Try job failure for 10905076-10006 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 10:27:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10905076/10006
8 years, 3 months ago (2012-09-07 17:11:14 UTC) #9
commit-bot: I haz the power
Try job failure for 10905076-10006 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 20:52:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10905076/10006
8 years, 3 months ago (2012-09-10 12:06:44 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 14:42:55 UTC) #12 
Change committed as 155724

Powered by Google App Engine
This is Rietveld 408576698