Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1090453003: Return correctly mapped bounds from GrOvalRenderer. (Closed)

Created:
5 years, 8 months ago by egdaniel
Modified:
5 years, 8 months ago
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Return correctly mapped bounds from GrOvalRenderer. Before we were returning non transformed bounds for the ovals instead of device bounds from the various draw calls. This was causing us to do dst copies from the wrong portion of the screen when there was some transform on the matrix. This fixes the gpu issues from the new imagefilters-xfermodes gm as well an old bug from the srcmode GM. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9ef1bb1375e66d9aac1124e005b500cb6d9caf01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 15 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
egdaniel
5 years, 8 months ago (2015-04-20 19:11:17 UTC) #2
joshualitt
On 2015/04/20 19:11:17, egdaniel wrote: lgtm
5 years, 8 months ago (2015-04-20 19:18:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090453003/1
5 years, 8 months ago (2015-04-20 19:22:42 UTC) #5
robertphillips
lgtm
5 years, 8 months ago (2015-04-20 19:23:05 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 19:29:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ef1bb1375e66d9aac1124e005b500cb6d9caf01

Powered by Google App Engine
This is Rietveld 408576698