[iOS] Upstream observer bridges

[iOS] Upstream observer bridges

PrefObserverBridge and SyncObserverBridge are C++ classes that bridge C++
observer event to Objective-C classes.

BUG=429756
Committed: https://crrev.com/f80bd9055bdc801344ae494800a3d6740796f7c1
Cr-Commit-Position: refs/heads/master@{#326566}

[sdefresne, 2015-04-23 16:47:32]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-23 16:48:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090413007/1

[sdefresne, 2015-04-23 16:48:36]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-04-23 16:48:37]

PTAL

[droger, 2015-04-23 16:49:50]

lgtm

[commit-bot: I haz the power, 2015-04-23 16:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 16:53:14]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[sdefresne, 2015-04-23 16:56:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2015-04-23 16:56:28]

Forgot to add some files in previous patchset, please take another look.

[commit-bot: I haz the power, 2015-04-23 16:56:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090413007/20001

[droger, 2015-04-23 17:00:54]

Lgtm with nit

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/pref...
File ios/chrome/browser/prefs/pref_observer_bridge.mm (right):

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/pref...
ios/chrome/browser/prefs/pref_observer_bridge.mm:9: #include
"base/prefs/pref_change_registrar.h"
Logging is not needed.

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/sync_observer_bridge.mm (right):

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/sync_observer_bridge.mm:7: #include
"components/sync_driver/sync_service.h"
logging.h

[sdefresne, 2015-04-23 17:04:42]

Thank you for the review.

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/pref...
File ios/chrome/browser/prefs/pref_observer_bridge.mm (right):

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/pref...
ios/chrome/browser/prefs/pref_observer_bridge.mm:9: #include
"base/prefs/pref_change_registrar.h"
On 2015/04/23 17:00:54, droger wrote:
> Logging is not needed.

Done.

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/sync_observer_bridge.mm (right):

https://codereview.chromium.org/1090413007/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/sync_observer_bridge.mm:7: #include
"components/sync_driver/sync_service.h"
On 2015/04/23 17:00:54, droger wrote:
> logging.h

Done.

[sdefresne, 2015-04-23 17:05:31]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-04-23 17:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1090413007/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2015-04-23 17:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090413007/40001

[commit-bot: I haz the power, 2015-04-23 17:38:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-23 17:40:31]

Patchset 3 (id:??) landed as
https://crrev.com/f80bd9055bdc801344ae494800a3d6740796f7c1
Cr-Commit-Position: refs/heads/master@{#326566}