Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1090393003: Simplified 'return' handling in the instruction selector. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplified 'return' handling in the instruction selector. The RawMachineAssembler now behaves like the rest of TurboFan, removing the need for some special cases. Committed: https://crrev.com/8aa7215246bbf56a4f2673897c5dc16c9f0e365d Cr-Commit-Position: refs/heads/master@{#28028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M src/compiler/instruction-selector.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-23 12:09:02 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-23 12:10:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090393003/1
5 years, 8 months ago (2015-04-23 12:14:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 12:39:41 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 12:39:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aa7215246bbf56a4f2673897c5dc16c9f0e365d
Cr-Commit-Position: refs/heads/master@{#28028}

Powered by Google App Engine
This is Rietveld 408576698