Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h

Issue 1090373003: Allow cross dependencies between BCKSF and BSKSF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix dependencies and DCHECK in Get{Original,Underlying}ContextInternal Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h
diff --git a/components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h b/components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h
index fae4b53325a6c8471d6c746512489e2b41303a4b..f151183f84afc9020c25c43afda60b7bde558049 100644
--- a/components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h
+++ b/components/keyed_service/ios/refcounted_browser_state_keyed_service_factory.h
@@ -115,9 +115,9 @@ class KEYED_SERVICE_EXPORT RefcountedBrowserStateKeyedServiceFactory
private:
// Registers any user preferences on this service. This is called by
- // RegisterProfilePrefsIfNecessary() and should be overriden by any service
+ // RegisterPrefsIfNecessaryForContext() and should be overriden by any service
// that wants to register profile-specific preferences.
- virtual void RegisterProfilePrefs(
+ virtual void RegisterBrowserStatePrefs(
user_prefs::PrefRegistrySyncable* registry) {}
// RefcountedKeyedServiceFactory:
@@ -126,8 +126,10 @@ class KEYED_SERVICE_EXPORT RefcountedBrowserStateKeyedServiceFactory
bool IsOffTheRecord(base::SupportsUserData* context) const final;
// KeyedServiceBaseFactory:
- user_prefs::PrefRegistrySyncable* GetAssociatedPrefRegistry(
- base::SupportsUserData* context) const final;
+ base::SupportsUserData* GetUnderlyingContextInternal(
+ base::SupportsUserData* context) const override;
+ base::SupportsUserData* GetOriginalContextInternal(
+ base::SupportsUserData* context) const override;
base::SupportsUserData* GetContextToUse(
base::SupportsUserData* context) const final;
bool ServiceIsCreatedWithContext() const final;

Powered by Google App Engine
This is Rietveld 408576698