Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/keyed_service/ios/browser_state_keyed_service_factory.h

Issue 1090373003: Allow cross dependencies between BCKSF and BSKSF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix dependencies and DCHECK in Get{Original,Underlying}ContextInternal Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/ios/browser_state_keyed_service_factory.h
diff --git a/components/keyed_service/ios/browser_state_keyed_service_factory.h b/components/keyed_service/ios/browser_state_keyed_service_factory.h
index 9f3d366414116fcfd6195d066e9677110cc1ee44..42935d06c409653ba923255dd571b343e14b6244 100644
--- a/components/keyed_service/ios/browser_state_keyed_service_factory.h
+++ b/components/keyed_service/ios/browser_state_keyed_service_factory.h
@@ -108,9 +108,9 @@ class KEYED_SERVICE_EXPORT BrowserStateKeyedServiceFactory
private:
// Registers any user preferences on this service. This is called by
- // RegisterProfilePrefsIfNecessary() and should be overriden by any service
+ // RegisterPrefsIfNecessaryForContext() and should be overriden by any service
// that wants to register profile-specific preferences.
- virtual void RegisterProfilePrefs(
+ virtual void RegisterBrowserStatePrefs(
user_prefs::PrefRegistrySyncable* registry) {}
// KeyedServiceFactory:
@@ -119,8 +119,10 @@ class KEYED_SERVICE_EXPORT BrowserStateKeyedServiceFactory
bool IsOffTheRecord(base::SupportsUserData* context) const final;
// KeyedServiceBaseFactory:
- user_prefs::PrefRegistrySyncable* GetAssociatedPrefRegistry(
- base::SupportsUserData* context) const final;
+ base::SupportsUserData* GetUnderlyingContextInternal(
+ base::SupportsUserData* context) const override;
+ base::SupportsUserData* GetOriginalContextInternal(
+ base::SupportsUserData* context) const override;
base::SupportsUserData* GetContextToUse(
base::SupportsUserData* context) const final;
bool ServiceIsCreatedWithContext() const final;

Powered by Google App Engine
This is Rietveld 408576698