Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: components/keyed_service.gypi

Issue 1090373003: Allow cross dependencies between BCKSF and BSKSF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix dependencies and DCHECK in Get{Original,Underlying}ContextInternal Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service.gypi
diff --git a/components/keyed_service.gypi b/components/keyed_service.gypi
index 22ebf665dae2b2e14fd373ea3c321da51b8c9cf8..61069652f85936c16612f958c9c54436d142eb75 100644
--- a/components/keyed_service.gypi
+++ b/components/keyed_service.gypi
@@ -18,6 +18,8 @@
'msvs_disabled_warnings': [ 4267, ],
'dependencies': [
'../base/base.gyp:base',
+ '../base/base.gyp:base_prefs',
+ 'user_prefs',
],
'sources': [
'keyed_service/core/dependency_graph.cc',
@@ -55,12 +57,10 @@
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
'dependencies': [
- 'keyed_service_core',
'../base/base.gyp:base',
- '../base/base.gyp:base_prefs',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../content/content.gyp:content_common',
- 'user_prefs',
+ 'keyed_service_core',
],
'include_dirs': [
'..',
@@ -89,7 +89,6 @@
],
'dependencies': [
'../base/base.gyp:base',
- '../base/base.gyp:base_prefs',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../ios/web/ios_web.gyp:ios_web',
'keyed_service_core',
« no previous file with comments | « no previous file | components/keyed_service/content/BUILD.gn » ('j') | components/keyed_service/core/keyed_service_base_factory.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698