Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: components/keyed_service/ios/browser_state_context_converter.h

Issue 1090373003: Allow cross dependencies between BCKSF and BSKSF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove wrapper methods Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/keyed_service/ios/DEPS ('k') | components/keyed_service/ios/browser_state_context_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/keyed_service/ios/browser_state_context_converter.h
diff --git a/components/keyed_service/ios/browser_state_context_converter.h b/components/keyed_service/ios/browser_state_context_converter.h
new file mode 100644
index 0000000000000000000000000000000000000000..7af647d4f410b2556d56cf2b760e24dd7c8abe5d
--- /dev/null
+++ b/components/keyed_service/ios/browser_state_context_converter.h
@@ -0,0 +1,55 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_KEYED_SERVICE_IOS_BROWSER_STATE_CONTEXT_CONVERTER_H_
+#define COMPONENTS_KEYED_SERVICE_IOS_BROWSER_STATE_CONTEXT_CONVERTER_H_
+
+#include "base/macros.h"
+
+namespace base {
+class SupportsUserData;
+}
+
+// BrowserStateContextConverter does safe conversion of base::SupportsUserData*
+// to web::BrowserState* or content::BrowserContext*.
+//
+// iOS code is still using BrowserContextKeyedServiceFactory and until the
+// conversion is complete — http://crbug.com/478763 — there is need to have
+// mixed dependency between BCKSF and BSKSF.
+//
+// The implementation has BrowserStateKeyedServiceFactory supporting a
+// BrowserContextDependencyManager as DependencyManager. Thus the context
+// parameter passed to the BrowserStateKeyedServiceFactory can either be
+// content::BrowserContext if the method is invoked by DependencyManager
+// or web::BrowserState if the method is invoked via the type-safe public
+// API.
+//
+// The public API of BrowserStateKeyedServiceFactory is type-safe (all
+// public method receive web::BrowserState for context object), so only
+// methods that take a base::SupportsUserData need to discriminate
+// between the two objects.
+class BrowserStateContextConverter {
+ public:
+ // Sets/Gets the global BrowserStateContextConverter instance. May return null
+ // when mixed dependencies are disabled.
+ static void SetInstance(BrowserStateContextConverter* instance);
+ static BrowserStateContextConverter* GetInstance();
+
+ // Converts |context| to a web::BrowserState* and returns it casted as a
+ // base::SupportsUserData*.
+ virtual base::SupportsUserData* GetBrowserStateForContext(
+ base::SupportsUserData* context) = 0;
+ // Converts |context| to a content::BrowserContext* and returns it casted as a
+ // base::SupportsUserData*.
+ virtual base::SupportsUserData* GetBrowserContextForContext(
+ base::SupportsUserData* context) = 0;
+
+ protected:
+ BrowserStateContextConverter();
+ virtual ~BrowserStateContextConverter();
+
+ DISALLOW_COPY_AND_ASSIGN(BrowserStateContextConverter);
+};
+
+#endif // COMPONENTS_KEYED_SERVICE_IOS_BROWSER_STATE_CONTEXT_CONVERTER_H_
« no previous file with comments | « components/keyed_service/ios/DEPS ('k') | components/keyed_service/ios/browser_state_context_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698