Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1090333002: Adding missing V8_EXPORT flag in SpaceStatistics class in v8.h (Closed)

Created:
5 years, 8 months ago by ssid
Modified:
5 years, 8 months ago
CC:
rmcilroy, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding missing V8_EXPORT flag in SpaceStatistics class in v8.h This class was added in crrev.com/1058253003 and missed V8_EXPORT in definition. BUG=466141, 476013 LOG=Y Committed: https://crrev.com/4a597f527a657846210edcc69e2b20ff1ba02afd Cr-Commit-Position: refs/heads/master@{#27926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ssid
5 years, 8 months ago (2015-04-17 18:37:22 UTC) #2
Hannes Payer (out of office)
LGTM
5 years, 8 months ago (2015-04-17 18:40:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090333002/1
5 years, 8 months ago (2015-04-17 18:46:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 19:33:25 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 19:33:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a597f527a657846210edcc69e2b20ff1ba02afd
Cr-Commit-Position: refs/heads/master@{#27926}

Powered by Google App Engine
This is Rietveld 408576698