Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 109033003: Fix a race between concurrent recompilation and OSR. (Closed)

Created:
6 years, 12 months ago by ulan
Modified:
6 years, 12 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix a race between concurrent recompilation and OSR. If concurrent recompilation finishes before OSR, then OSR replaces the old optimized code without evicting it from the optimized code map. New functions can get the old optimized code from the optimized code map, but the old code could be already deoptimized. BUG=330046 TEST=test/mjsunit/regress-330046.js LOG=Y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/regress-330046.js View 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look.
6 years, 12 months ago (2013-12-24 11:42:26 UTC) #1
Yang
On 2013/12/24 11:42:26, ulan wrote: > Please take a look. LGTM.
6 years, 12 months ago (2013-12-24 12:45:46 UTC) #2
ulan
6 years, 12 months ago (2013-12-27 09:23:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698